Repository navigation
fix(pipes): include the pipe lint in static reports - #286
Conversation
pipe-lint is a pure source scan like get-pipes, but it was registered without snapshot: true, so pangular build never stored its result. In a static report the Pipes tab's Lint section always showed that the check could not run, and Refresh could not fix it. It is now baked in like the other source scans.
🚀 Deploying Preview to Cloudflare 🚀Preview Deployments by commit
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk | ⚪ Minimal · up to
|
What and why
A static report (
pangular build) stores the results of RPC functions registered withsnapshot: true.pipe-linttakes no arguments and only reads source, likeget-pipes, but it had nosnapshot: true.collectStaticRpcDumpskipped it, and the dump client threwDF0025when the panel called it.In a shared report the Pipes tab's Lint section always said "Couldn't run the lint check. Try Refresh." Refresh can't help, so none of the four lint rules ever appeared in a report.
The fix adds
snapshot: trueto thepipe-lintregistration.How it was verified
rpc/__tests__/static-dump.test.tsnow listspipe-lintamong the baked-in source scans. A new test builds a dump for a fixture component using| jsonand reads thejson-pipe-in-templatefinding back through devframe's dump client. Both fail onmain(the function is missing, andDF0025) and pass with the fix. All package tests pass.pnpm commit:check(commit messages follow the guidelines)pnpm format:checkpnpm typecheck(includes thengctemplate checks)pnpm test:devtools(all passing)pnpm skills:check(when.claude/changed): not changedno-docs)pnpm extension:buildandextension/uicommitted (whenapp/changed): not changedSummary by CodeRabbit
jsonpipe.