Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions packages/devtools/src/__tests__/serialize.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,14 @@ describe('serialize', () => {
expect(serialize('abcdef', { text: 3 })).toBe('abc…');
});

it('keeps a real "…" key when the key limit adds its marker', () => {
expect(serialize({ '…': 'real', b: 2, c: 3 }, { keys: 2 })).toEqual({
'…': 'real',
b: 2,
'… (2)': '1 more',
});
});

it('marks text cut by the redaction window when the text limit is larger', () => {
const out = serialize('a'.repeat(70000), { text: 100000 }) as string;
expect(out).toBe(`${'a'.repeat(65536)}…`);
Expand Down
3 changes: 2 additions & 1 deletion packages/devtools/src/serialize.ts
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,8 @@ export function serialize(value: unknown, limits: SerializeLimits = {}): unknown
}
setKey(out, safeKey(key, out), walkNamed(key, item, level + 1));
}
if (keys.length > maxKeys) out['…'] = `${keys.length - maxKeys} more`;
// Through safeKey, so the marker never replaces a real `…` key.
if (keys.length > maxKeys) setKey(out, safeKey('…', out), `${keys.length - maxKeys} more`);
return out;
} finally {
path.delete(v);
Expand Down
Loading