Skip to content

Update _types.py - #2964

Open
Flyguy wants to merge 5 commits into
pallets-eco:masterfrom
Flyguy:patch-1
Open

Flyguy wants to merge 5 commits into
pallets-eco:masterfrom
Flyguy:patch-1

Conversation

@Flyguy

@Flyguy Flyguy commented Oct 2, 2026

Copy link
Copy Markdown

If flask_sqlalchemy doesn't used. It will throw exception.

If flask_sqlalchemy doesn't used. It will throw exception.

@hasansezertasan hasansezertasan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this fixes a real optional-dependency import failure. Please run pre-commit to clear the style failure and add a regression check for importing flask_admin.contrib.sqla.ModelView without Flask-SQLAlchemy installed.

@ElLorans

Copy link
Copy Markdown
Collaborator

The regression check is already in #2959, @Flyguy you can fork cjmayo:test-flask-sqlalchemy-lite and PR directly the author. To run pre-commit you can run pre-commit install as outlined in the readme and then every commit will trigger it. I think you can also trigger it manually with pre-commit run --all-files

@hasansezertasan

Copy link
Copy Markdown
Member

Thanks for pointing out #2959—I missed that existing coverage. No need to duplicate it here. Once formatting is fixed, let’s verify this fix with the Lite-only test environment from #2959.

@Flyguy Flyguy left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

White space fixed

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants