Skip to content

Create Team page with modular card layout (#60) #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
q404365631 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Create Team page with modular card layout (#60) #98

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 31 additions & 0 deletions team.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
---
layout: page
title: Team
permalink: /team/
---
Comment on lines +1 to +5
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot Apr 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

According to the repository style guide (lines 50 and 78), every change must be accompanied by an update to the site_version in _config.yml and a new entry in CHANGELOG.md. These updates are missing from this pull request.

References
  1. Whenever you do a change to the file, please update the version: field in rubycon.it/_config.yml (with semantic versioning) and CHANGELOG.md. (link)


<div class="team-grid">
{% for member in site.team %}
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot Apr 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The template iterates over site.team, but this data is not defined in the provided _config.yml. To ensure the page displays content, the team members' data should be added to the configuration file as mentioned in the PR description.

<div class="team-card">
<img src="{{ member.avatar }}" alt="{{ member.name }}" class="team-avatar">
<h3>{{ member.name }}</h3>
<p class="role">{{ member.role }}</p>
<p class="bio">{{ member.bio }}</p>
<div class="links">
{% if member.github %}<a href="{{ member.github }}">GitHub</a>{% endif %}
{% if member.twitter %}<a href="{{ member.twitter }}">Twitter</a>{% endif %}
</div>
</div>
{% endfor %}
</div>

<style>
.team-grid { display: grid; grid-template-columns: repeat(auto-fill, minmax(280px, 1fr)); gap: 2rem; padding: 2rem; }
.team-card { background: var(--card-bg); border-radius: 12px; padding: 1.5rem; text-align: center; box-shadow: 0 2px 8px rgba(0,0,0,0.1); transition: transform 0.2s; }
.team-card:hover { transform: translateY(-4px); }
.team-avatar { width: 100px; height: 100px; border-radius: 50%; object-fit: cover; margin-bottom: 1rem; }
.team-card h3 { margin: 0.5rem 0; color: var(--heading-color); }
.role { color: var(--accent-color); font-weight: 600; font-size: 0.9rem; margin: 0.5rem 0; }
.bio { color: var(--text-muted); font-size: 0.85rem; line-height: 1.5; }
.links a { margin: 0 0.5rem; color: var(--link-color); text-decoration: none; }
Comment on lines +23 to +30
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot Apr 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The CSS uses several variables (e.g., var(--card-bg), var(--accent-color)) that are not defined in the project's _variables.scss. Additionally, the .team-grid padding might conflict with the existing padding in the page layout (px-6 md:px-8). Given the project's recent move to a 'Roman' theme (Wine Red #802126 and Cream #fcf7e8) and the use of Tailwind CSS in other layouts (as seen in _layouts/page.html), consider using Tailwind classes or the established color palette for better consistency.

</style>