🎨 fix(newsletter): Remove unnecessary data attributes from newsletter…#97
🎨 fix(newsletter): Remove unnecessary data attributes from newsletter…#97ludovicobesana wants to merge 1 commit intomainfrom
Conversation
✅ Deploy Preview for rubycon ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes the data-sv-form and data-uid attributes from the newsletter subscription form in rubycon.it/_includes/newsletter.html. The review feedback correctly points out that the PR is missing mandatory updates to the site_version in _config.yml and the CHANGELOG.md, as required by the repository's style guide for every file change.
| Stay in the loop | ||
| </h3> | ||
| <form action="https://app.convertkit.com/forms/8a5a8f8636/subscriptions" method="post" data-sv-form="8a5a8f8636" data-uid="8a5a8f8636" class="flex items-center gap-4 w-full h-[40px]" style="max-width: 448px;"> | ||
| <form action="https://app.convertkit.com/forms/8a5a8f8636/subscriptions" method="post" class="flex items-center gap-4 w-full h-[40px]" style="max-width: 448px;"> |
There was a problem hiding this comment.
According to the repository style guide (lines 50 and 78), any change to a file requires updating the site_version in rubycon.it/_config.yml and adding a corresponding entry to CHANGELOG.md. Please ensure these updates are included in this pull request to maintain consistency with the project's versioning and documentation standards.
References
- Requirement to update site_version in _config.yml and CHANGELOG.md for every file change. (link)
|
per me va bene -> Ma chiederei a @emilianodellacasa di approvare. LGTM |
2 participants
Close #13