feat(dashboard): log pager — match count, rows-per-page, prev/next; grouping dropdown retired - #840
Merged
Merged
Conversation
…rouping dropdown retired The grouping dropdown answered a strictly weaker question once range presets, date jumps and search owned the time navigation — it becomes a pager: '<N> entries · page X of Y', a 5/10/20/50/100 rows-per-page select, and Prev/Next. Paging is client-side over the server-filtered, bounded result set; pageFor clamps so a shrinking result set never strands the view past the end, and the page resets to 0 on any filter change (a new question starts at its first page). Both cards page identically — the access card's special filtered-vs-glance cap split dies with the grouping code (bucketKey, groupAuditEntries, the group-header rows and their CSS). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…(verifier findings) - pageFor falls back to the default page size on a 0/NaN/negative size and a non-finite page — a hostile value reaching the division would render 'page NaN of Infinity'. The clamp is the safety net behind every pager callback: a stale page lands on the last real page. - The edge-disabling test now asserts the disabled attribute's presence/absence per pager (scoped by aria-label), plus a last-page case — previously it only matched button text. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #838, per operator direction: with range presets, date jumps and search owning the time navigation, the hour/day/month grouping dropdown answered a strictly weaker question — it becomes a pager.
pageForclamps so a shrinking result set never strands the view past the end; the page resets to 0 on any filter change.bucketKey,groupAuditEntries, the group-header rows and their CSS). Net: the diff deletes more logic than it adds.docs/dashboard.mdupdated to match; deep history stays a documented pointer to the host files rather than dashboard scope.Coverage:
pageForunit tests (slicing, clamping, empty-set), pager render tests (count line, per-page select, edge disabling, page-2 slice boundaries), flat-audit-rendering regression, and the #838 filter tests updated to the paging model. Frontend suite green (14/14 securityview + full run), dashboard 1649 pass,make lintclean.🤖 Generated with Claude Code