fix(compose): tari-wallet healthcheck pattern survives ps CMD truncation - #800
Merged
Merged
Conversation
procps' ps caps the CMD column at 15 characters, so the probe's grep for the 23-character 'minotari_console_wallet' could never match: the wallet container reported unhealthy forever while the wallet ran fine. Match on '[m]inotari_consol' — the truncated form ps actually prints. Closes #777 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
procps'
pscaps its CMD column at 15 characters, so the tari-wallet healthcheck's grep for the 23-characterminotari_console_walletcan never match: the container reports unhealthy forever while the wallet runs fine. Latent in production only because no deployment hastari_payout_confirmactive yet — the first real user of #462 would get a permanently-firing container-unhealthy alert.Match on
[m]inotari_consol— the truncated formpsactually prints (verified inside the running image on the #77 phase-2 bench, where the failure was found).Coverage
Stack tier (
tests/stack/test_compose.sh), beside the existing[m]inotariself-match assertion: the tari-wallet pattern must contain the truncation-safe form and must not carry the full binary name. Asserted against thetari_payout_confirmprofile render, since the service does not exist in the default render.Closes #777
🤖 Generated with Claude Code