Skip to content

chore: release v1.5.0#72

Merged
pushpender-singh-ap merged 1 commit into
mainfrom
release/1.5.0
Jun 26, 2026
Merged

chore: release v1.5.0#72
pushpender-singh-ap merged 1 commit into
mainfrom
release/1.5.0

Conversation

@pushpender-singh-ap

Copy link
Copy Markdown
Member

Release v1.5.0

Bumps the app version from 1.4.9 → 1.5.0 for the 1.5.0 release.

Version changes

  • Android: versionCode 38 → 39, versionName 1.4.9 → 1.5.0
  • iOS: marketing version bumped to 1.5.0 (project.pbxproj, Podfile.lock)
  • package.json: version → 1.5.0
  • Pinned react-native-nitro-modules to 0.30.2

What's included in 1.5.0

  • Landscape orientation support and improved responsive layout
  • Removed hardcoded User-Agent / Accept-Encoding headers from novel APIs

Files changed

  • android/app/build.gradle
  • ios/InkNest.xcodeproj/project.pbxproj
  • ios/Podfile.lock
  • package.json
  • yarn.lock

@pushpender-singh-ap pushpender-singh-ap self-assigned this Jun 26, 2026
@pushpender-singh-ap pushpender-singh-ap marked this pull request as ready for review June 26, 2026 11:56
@qodo-code-review

Copy link
Copy Markdown

PR Summary by Qodo

Release v1.5.0: bump mobile build versions + pin nitro modules
⚙️ Configuration changes 🕐 10-20 Minutes

Grey Divider

Description

• Bump Android and iOS build versions to 1.5.0 for the v1.5.0 release.
• Refresh iOS project CocoaPods script-phase metadata after running pod install.
• Pin react-native-nitro-modules to 0.30.2 and update lockfiles.
Diagram

graph TD
  A["Release v1.5.0 PR"] --> B["android/app/build.gradle"] --> C["Android version 1.5.0"]
  A --> D["ios/.../project.pbxproj"] --> E["iOS marketing 1.5.0"]
  A --> F["package.json"] --> G["yarn.lock"] --> H["ios/Podfile.lock"]
Loading
High-Level Assessment

The following are alternative approaches to this PR:

1. Use Yarn resolutions/overrides instead of direct pin
  • ➕ Keeps package.json semver intent while forcing a known-good transitive version
  • ➕ Easier to revert after upstream fix
  • ➖ Less explicit for future maintainers scanning dependencies
  • ➖ Still requires lockfile churn; may confuse tooling if not documented
2. Upgrade to latest nitro-modules and fix breakage
  • ➕ Avoids long-term divergence from upstream
  • ➕ May include performance/bug fixes needed later
  • ➖ Higher risk for a release PR; could introduce new runtime/native issues
  • ➖ Potentially larger follow-up changes across iOS/Android native code
3. Patch-package/vendor minimal fixes while staying on newer version
  • ➕ Can keep newer upstream version while addressing a specific regression
  • ➕ More targeted than a full downgrade
  • ➖ Adds maintenance burden and hidden complexity
  • ➖ Patches may break on next dependency update

Recommendation: For a release branch, the current approach (explicitly pinning react-native-nitro-modules to 0.30.2 and regenerating lockfiles) is the lowest-risk stabilization move. If the pin is meant to be temporary, consider adding a short note in release docs/issue tracker and follow up post-release to either move the pin into resolutions (with rationale) or re-upgrade and address any upstream incompatibility.

Files changed (5) +27 / -11

Other (5) +27 / -11
build.gradleBump Android versionCode/versionName for v1.5.0 +0/-0

Bump Android versionCode/versionName for v1.5.0

• Updates the Android app version metadata to versionCode 39 and versionName 1.5.0 to match the release.

android/app/build.gradle

project.pbxprojBump iOS marketing version and refresh CocoaPods build phases +26/-10

Bump iOS marketing version and refresh CocoaPods build phases

• Updates MARKETING_VERSION to 1.5.0 for Debug/Release. Also adds empty inputPaths/outputPaths entries and normalizes some linker flag settings, consistent with CocoaPods/Xcode project regeneration.

ios/InkNest.xcodeproj/project.pbxproj

Podfile.lockRegenerate Podfile.lock after dependency/pod install changes +0/-0

Regenerate Podfile.lock after dependency/pod install changes

• Updates the CocoaPods lockfile to reflect the current installed pod set after the release/dependency adjustments (including NitroModules sourced from node_modules).

ios/Podfile.lock

package.jsonPin react-native-nitro-modules to 0.30.2 +1/-1

Pin react-native-nitro-modules to 0.30.2

• Replaces the semver range with an exact version for react-native-nitro-modules to ensure deterministic installs for the release.

package.json

yarn.lockUpdate yarn.lock for pinned nitro-modules version +0/-0

Update yarn.lock for pinned nitro-modules version

• Regenerates the lockfile so react-native-nitro-modules resolves to 0.30.2 consistently across environments.

yarn.lock

@qodo-code-review

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (1) 📘 Rule violations (0) 📜 Skill insights (0)

Grey Divider


Remediation recommended

1. JS version mismatch 🐞 Bug ≡ Correctness
Description
For the 1.5.0 release, Android/iOS versions are set to 1.5.0 but package.json still declares version
0.0.1, leaving the repo with conflicting version sources. Any tooling that reads package.json for
build/release metadata may produce incorrect artifacts or tags.
Code

package.json[52]

+    "react-native-nitro-modules": "0.30.2",
Evidence
The repository’s native version metadata has been bumped to 1.5.0 (Android versionName, iOS
MARKETING_VERSION), while package.json still declares version 0.0.1, creating inconsistent
release/version sources.

package.json[1-5]
android/app/build.gradle[83-90]
ios/InkNest.xcodeproj/project.pbxproj[631-685]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

### Issue description
Native app versions are already bumped to **1.5.0**, but `package.json.version` is still `0.0.1`. This leaves the repository in an inconsistent state for a release PR and can cause JS/CI/release workflows that read `package.json.version` to use the wrong version.

### Issue Context
- Android is already set to `versionName "1.5.0"`.
- iOS uses `CFBundleShortVersionString = $(MARKETING_VERSION)` and `MARKETING_VERSION = 1.5.0`.
- `package.json` still reports `"version": "0.0.1"`.

### Fix Focus Areas
- package.json[1-5]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


Grey Divider

Qodo Logo

@pushpender-singh-ap pushpender-singh-ap added this pull request to the merge queue Jun 26, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to Branch Protection failures Jun 26, 2026
You're not authorized to push to this branch. Visit "About protected branches" for more information.
@pushpender-singh-ap pushpender-singh-ap merged commit 37277fc into main Jun 26, 2026
1 check passed
@pushpender-singh-ap pushpender-singh-ap deleted the release/1.5.0 branch June 26, 2026 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants