perf: enhance tokens block memory usage - #486
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #486 +/- ##
==========================================
- Coverage 71.12% 71.04% -0.08%
==========================================
Files 232 232
Lines 18404 18533 +129
==========================================
+ Hits 13089 13167 +78
- Misses 4337 4383 +46
- Partials 978 983 +5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
@seqbenchbot start search-regular main 'k8s_pod:-eu-' --duration 5m |
|
Nice, @dkharms Started benchmark Show details
I'll post the statistics here once it finishes. Here is a list of helpful links: Have a great time! |
|
Nice, @dkharms Benchmark Show summary
Compare it against another run with |
|
@seqbenchbot start search-regular 0-enhance-token-block-memory 'k8s_pod:-eu-' --duration 5m |
|
Nice, @dkharms Started benchmark Show details
I'll post the statistics here once it finishes. Here is a list of helpful links: Have a great time! |
|
Nice, @dkharms Benchmark Show summary
Compare it against another run with |
Description
Memory reduction (prod fraction):
message:*foobar*25335032 => 20584912 bytes
message:*87466437*71844952 => 58236912
Performance improvement: 5-10% for wildcards like
message:*5647545*(cold requests). For wildcards with letters there is no benefit - we block on disk read time more since we skip blocks.