feat: store .remote-info for remote shards to avoid extra S3 - #436
feat: store .remote-info for remote shards to avoid extra S3#436eguguchkin wants to merge 2 commits into
Conversation
🔴 Performance DegradationSome benchmarks have degraded compared to the previous run. Show table
|
a76acff to
ed1cec9
Compare
🔴 Performance DegradationSome benchmarks have degraded compared to the previous run. Show table
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #436 +/- ##
==========================================
+ Coverage 71.16% 71.17% +0.01%
==========================================
Files 232 232
Lines 18466 18546 +80
==========================================
+ Hits 13141 13201 +60
- Misses 4343 4351 +8
- Partials 982 994 +12 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
By the way, we can get rid of this awkward return signature (bool, error) and just return error because fractionProvider will always try to offload sealed fractions.
If you remember, I've added this boolean to distinguish between offloading attempts of active and sealed fractions.
| } | ||
|
|
||
| remoteInfoName := f.BaseFileName + consts.RemoteFractionInfoSuffix | ||
| err = util.WriteFileAtomic(remoteInfoName, info, 0o666, ".tmp") |
There was a problem hiding this comment.
Seems like if seq-db crashes (for some reason) in the middle of util.WriteFileAtomic and we end up with seq-db-*.remote-info.tmp -- it won't be able to boot.
I guess it's better to just perform rename from .info to .remote-info, right?
b937622 to
8bb796f
Compare
8bb796f to
ef2ec2d
Compare
Fixes #435