Conversation
This is a dependency for some other work
When making a build to test it's useful to have a pre-generated CoRIM file. Generate one for each build. RoT builds will have two entries.
mkeeter
reviewed
Jun 10, 2026
| caboose_args | ||
| .version_override | ||
| .clone() | ||
| .unwrap_or("0.0.0-testing".to_string()), |
Collaborator
There was a problem hiding this comment.
Is there any benefit to using the git revision here?
Collaborator
Author
There was a problem hiding this comment.
We could, this is also designed to be used as a placeholder so 🤷
Collaborator
|
From pedantically browsing the lockfile changes, there are a few upstream crates that we could update to minimize the number of different versions in the dependency tree:
(this shouldn't block the PR, obviously) |
Collaborator
Author
I spotted that too and was going to take a pass at that after I got a few more things done
Ah good point. That repo needs some restructuring. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.