Repository navigation
Conversation
Contributor
|
@claude review |
Contributor
Author
|
The failing pagination tests here come from Rust 1.100 changing where Cargo puts test binaries, not from this change; the same assertion fails on any PR built with stable. #1771 fixes the test. |
ahl
approved these changes
Nov 18, 2026
The panic for a tuple-like array schema did not say which schema caused
it, which makes the offending type hard to find in a large API. The
message now ends with the array schema as JSON, for example
`{"items":[{"type":"boolean"},{"type":"string"}],"maxItems":2,"minItems":2}`.
Fixes oxidecomputer#1381
mliemm
force-pushed
the
fix/log-tuple-array-schema
branch
from
November 19, 2026 07:37
a5f4795 to
dcb29a6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1381.
j2oas_arraypanics withOpenAPI v3.0.x cannot support tuple-like arraysbut doesn't say which schema caused it, so finding the offending type in a large API means bisecting. The panic message now ends with the array schema as JSON. For example, a(bool, String)field gives:If the schema can't be serialized, the message falls back to its
Debugform. Apart from the message, nothing changes: a tuple-like array still panics.Testing
test_tuple_array_panic_shows_schema, a#[should_panic(expected = ...)]test that checks the full message for(bool, String). It fails with "panic did not contain expected string" when the old message is restored.cargo fmt -- --checkandcargo clippy --all-targets -- --deny warningsare clean.cargo test -p dropshotpasses: 144 unit tests, 101 integration tests and the doc tests.