Repository navigation
Conversation
Add a fresh UUIDv4 discriminator to each generated test log prefix. Include the test label, resolved logging configuration, and underlying error when logger creation fails, with a focused regression test for the contextual panic. Preserve existing file-opening policies and cleanup behavior. Fixes oxidecomputer#479
sekaiser
force-pushed
the
fix-479-log-prefix
branch
from
November 14, 2026 09:27
f2b57b2 to
e22b7eb
Compare
sekaiser
marked this pull request as ready for review
November 14, 2026 09:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repeated test executions can reuse a process ID and restart the per-process counter, selecting a log left behind by a failed run (oxidecomputer/omicron#1936). Generate a fresh UUIDv4 per
log_prefix_for_test()invocation so each prefix has its own random discriminator, independent of PID reuse and counter resets.The filename format changes to
{executable}-{test_name}.{pid}.{counter}.{uuid}.log, adding 33 characters with a 32-character hexadecimal UUID. Names are collision-resistant; generating a name creates or reserves no filesystem entry. Logger creation failures now include the test label, resolved configuration and destination, and original I/O error. Public signatures, temporary-directory selection, opening policies, and failure-artifact retention remain unchanged.Reviewed Omicron at
b65d3b429172b2b10ce1c4304f64de4405750560: trust-quorum, oximeter/db, and ClickHouse utilities consume prefixes opaquely. Directory-only callers retain their independently chosen paths. Reviewed concrete names, including suffixes and maximum-width PID/counter fields, remain below 255 bytes after the addition. No Omicron changes or truncation are needed.Fixes #479