chore: upgrade gRPC to 1.84.0 - #418
Merged
Merged
Conversation
Signed-off-by: Matteo Merli <mmerli@apache.org>
Signed-off-by: Matteo Merli <mmerli@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The client is on gRPC 1.75.0. 1.84.0 is the latest release, and since 1.83.0 grpc-java has been built and tested against Netty 4.2, which the client moves to in #417.
Modifications
grpcfrom 1.75.0 to 1.84.0 ingradle/libs.versions.toml.proto-google-common-protosfrom 2.59.2 to 2.64.1, the version grpc-protobuf 1.84.0 declares. The client lists it as a direct runtime dependency in its published POM. If it stayed at 2.59.2, Maven's nearest-wins rule would give Maven users 2.59.2 under grpc-protobuf 1.84. Gradle builds already resolved 2.64.1.Release notes for 1.76 through 1.84, checked against the client:
Connectionpasses the server address toGrpc.newChannelBuilderwithout a scheme (host:port, after removingtls://). In 1.84 the RFC 3986 path keeps the old fallback: a target that doesn't look likescheme:/...is resolved asdns:///<target>. Solocalhost:6648,127.0.0.1:6648and[::1]:6648resolve as before.LoadBalancers and SPIFFE, none of which the client uses. The one internal class it imports,io.grpc.internal.BackoffPolicy, is unchanged.Verification
./gradlew :client:dependencies --configuration runtimeClasspathresolves all 10io.grpcmodules to 1.84.0 and all 15io.nettymodules to 4.2.18.Final. The generated POM listsproto-google-common-protos2.64.1../gradlew buildpasses locally: 393 tests, no failures or skips, and no new compiler warnings. That includes all 7 Docker IT classes against a real Oxia server:OxiaClientIT,ClientReconnectIT,OxiaClientFailFastIT,RpcProviderIT,ShardSplitSessionIT,SharedResourcesITandNotificationIt.