fix(decomposedfs): [OCISDEV-817] remove stale trash symlink on partial delete rollback - #723
Merged
LarsJurgensen merged 1 commit intoAug 27, 2026
Conversation
…l delete rollback
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
LarsJurgensen
marked this pull request as ready for review
August 26, 2026 11:22
deyankiteworks
approved these changes
Aug 26, 2026
LarsJurgensen
deleted the
fix/OCISDEV-817-remove-stale-trash-symlink-on-delete-failure
branch
August 27, 2026 07:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In
Tree.Delete, a trash symlink is created before the node is renamed.If any subsequent step failed, the symlink was left behind. The dangling
symlink permanently blocked future delete attempts on the same node with
a
file existserror on the nextos.Symlinkcall.All three failure paths now remove the trash symlink as part of rollback.
The third path (parent-dir entry removal) additionally reverts the node
rename and metadata rename in reverse order.
Related Issue
Motivation and Context
A metadata backend failure mid-delete left a stale symlink in the trash
directory. The node appeared intact but could never be deleted again.