Repository navigation
Conversation
pmonfort
force-pushed
the
pm_playwright
branch
2 times, most recently
from
October 27, 2026 02:39
6fa8979 to
56e84dd
Compare
pmonfort
force-pushed
the
pm_playwright
branch
from
October 27, 2026 03:03
56e84dd to
c0e1707
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
AO3-1234 Fix thing)Issue
XXXXXX
Purpose
Proof of concept from the Slack discussion about checking that i18n PRs don't change any rendered text. Draft so we can discuss over real code.
It adds Playwright using the aria snapshots feature, which compares a page's visible text and elements without using screenshots. The baseline is a YAML file committed to the repo. When a PR changes any rendered text or element the build fails, and if the change is intentional the contributor runs a command to regenerate the YAML. It also catches the forgotten _html case, since the escaped markup shows up as literal text.
The proof of concept covers one test for the new work form and an informational CI job that boots the app with the
db:otwseedfixtures, so baselines are deterministic and match CI. The whole job takes about 2 minutes, most of it booting the app. One consideration is that this adds a Node toolchain to the CI. More details in playwright/README.mdTesting Instructions
No user-facing changes. To try it locally, follow
playwright/README.md: start a seeded test server and runnpm run test:playwrightagainst it. To see the failure mode, change any visible string in the work form views and run it again.References
Slack discussion in #ao3-coders about reviewing i18n PRs.
Credit
Pablo Monfort (he/him)