AO3-7408 Request invatations page title adjustment

[jmalark]

Pull Request Checklist

• Have you read "How to write the perfect pull request"?
• Have you read the contributing guidelines?
• Have you added tests for any changed functionality?
• Have you added the Jira issue number
  as the first thing in your pull request title (e.g. AO3-1234 Fix thing)
• Do you have fewer than 5 pull requests already open? If not, please wait
  until they are reviewed and merged before creating new pull requests.

Issue

https://otwarchive.atlassian.net/browse/AO3-7408

Purpose

Corrects the browser page title for the Request Invitations page

Credit

Jesse Malark he/him

[jmalark]

@sarken It didn't look like we were doing any RSpec tests for @page_subtitle getting set to hard coded strings (only ones based on variables) so I didn't add anything to user_invite_requests_controller_spec.rb. If you want me to throw a test in there for this, just let me know.

[sarken]

Thanks for working on this!

Regarding tests, we usually use Cucumber for the page titles -- you can find a bunch of examples if you search for either "I should see the page title" or "the page title should include."

In this case, adding Then the page title should include "Request Invitations" after line 9 in the first scenario in other_a/invite_request.feature should work.

[sarken]

This should also be changed to "Request Invitations" -- and if you could make it translatable like Reviewdog mentioned, we'd appreciate that!

[jmalark]

Ok changed the text and moved it to the en.yml file