AO3-3764 Paginate tag set nominations review page#5752
Open
pmonfort wants to merge 7 commits intootwcode:masterfrom
Open
AO3-3764 Paginate tag set nominations review page#5752pmonfort wants to merge 7 commits intootwcode:masterfrom
pmonfort wants to merge 7 commits intootwcode:masterfrom
Conversation
11f0ab0 to
0bb47cc
Compare
sarken
reviewed
Apr 23, 2026
| <%= check_all_none("Approve All", "Approve None", "approve") %> | ||
| <% if @paginations&.dig(tag_type) %> | ||
| <%== pagy_nav(@paginations[tag_type], | ||
| anchor_string: "id=\"#{tag_type}_nominations\"") %> |
Collaborator
There was a problem hiding this comment.
Question! Does the anchor_string here mean that the pagination links should be like ?fandom_page=3#fandom_nominations?
I swear I saw that behavior when I first pulled this code to try it out, but it has disappeared on me, so I'm confused. 😆
Contributor
Author
There was a problem hiding this comment.
Yes, that's the intended behavior! The anchor_string parameter name is a bit misleading, it refers to the HTML anchor element ( tag) not URL anchors/fragments. I've pushed a fix using the correct fragment parameter.
Good catch! Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
as the first thing in your pull request title (e.g.
AO3-1234 Fix thing)until they are reviewed and merged before creating new pull requests.
Issue
https://otwarchive.atlassian.net/browse/AO3-3764
Purpose
When a tag set has more than 30 unreviewed nominations, moderators currently see a random subset with the message "There are too many nominations to show at once." This makes it impossible to systematically review all nominations.
This PR replaces the random selection with proper pagination using pagy:
created_atascending for deterministic resultsTesting Instructions
Credit
Pablo Monfort (he/him)