AO3-6348 Fix autocomplete highlight escaping for pipe queries#5746
Open
noahbravo wants to merge 1 commit intootwcode:masterfrom
Open
AO3-6348 Fix autocomplete highlight escaping for pipe queries#5746noahbravo wants to merge 1 commit intootwcode:masterfrom
noahbravo wants to merge 1 commit intootwcode:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
AO3-1234 Fix thing)?Issue
https://otwarchive.atlassian.net/browse/AO3-6348
Purpose
Fixes an autocomplete highlighting issue where queries containing a pipe (
|) can result in malformed suggestions with a stray semicolon after ampersands.For example, typing
Evil Queen |could produce:Evil Queen | Regina Mills &; Henry Mills
instead of:
Evil Queen | Regina Mills & Henry Mills
This was caused by incomplete escaping of regex metacharacters in the autocomplete highlighting logic.
Changes made:
public/javascripts/jquery.tokeninput.jsto correctly escape|and other metacharacters.public/javascripts/jquery.tokeninput.min.jsaccordingly.features/other_a/autocomplete.featureto cover this case.Testing Instructions
Automated:
docker compose run --rm test bundle exec cucumber features/other_a/autocomplete.feature:264docker compose run --rm test bundle exec cucumber features/other_a/autocomplete.featureManual:
Follow the reproduction steps in AO3-6348:
https://otwarchive.atlassian.net/browse/AO3-6348
Expected behavior:
|).Evil Queen | Regina Mills & Henry MillsCredit
Name: Noah Bravo
Pronouns: they/them