AO3-7261 Challenges must allow at least one sign-up field#5745
Open
ayasayadi1 wants to merge 6 commits intootwcode:masterfrom
Open
AO3-7261 Challenges must allow at least one sign-up field#5745ayasayadi1 wants to merge 6 commits intootwcode:masterfrom
ayasayadi1 wants to merge 6 commits intootwcode:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
as the first thing in your pull request title (e.g.
AO3-1234 Fix thing)until they are reviewed and merged before creating new pull requests.
Issue
https://otwarchive.atlassian.net/browse/AO3-7261
Purpose
It's currently possible to save a Gift Exchange or Prompt Meme challenge without allowing any request/offer fields. Users later encounter errors when trying to sign up. This PR validates that at least one field (title, description, URL, tags) is allowed before saving the challenge.
Sign-ups fail when title is the only allowed field. This PR fixes that by adding title to the blank check in
ChallengeSignup.Credit
Aya Sayadi