AO3-7405 Prevent N+1 queries on tags#feed#5739
Open
Bilka2 wants to merge 3 commits intootwcode:masterfrom
Open
AO3-7405 Prevent N+1 queries on tags#feed#5739Bilka2 wants to merge 3 commits intootwcode:masterfrom
Bilka2 wants to merge 3 commits intootwcode:masterfrom
Conversation
github-actions
Bot
added
Scope: Tests Only
Bilka2
removed
the
Scope: Tests Only
brianjaustin
approved these changes
Apr 19, 2026
Member
brianjaustin
left a comment
brianjaustin
left a comment
There was a problem hiding this comment.
Thanks! (Just one unrelated thing that doesn't have to be addressed if you'd rather not)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
https://otwarchive.atlassian.net/browse/AO3-7405
Purpose
Prevent N+1 queries on tags#feed by using
includes. The change in the feed builder itself is helpful because the previous code would get the works twice (once with limit 1 and once with limit 25), and that query is potentially quite slow. It's much faster to only do the limit 25 query and grab the date from the first work in the loop.Failing test for the N+1 (and passing test for the feed date) pushed first to show that they're testing the right thing.
Credit
Bilka