AO3-7267 Return 404 on the preferences page for nonexistent users#5726
AO3-7267 Return 404 on the preferences page for nonexistent users#5726CelineB-sudo wants to merge 2 commits intootwcode:masterfrom
Conversation
sarken
left a comment
sarken
left a comment
There was a problem hiding this comment.
Hi, Céline Bertaud!
Thank you so much for this pull request. It looks good to me except for a tiny nitpick about the test phrasing, so I've marked it Ready to Merge! If you have a second to address the phrasing issue, though, we'd appreciate it.
If you'd like the ability to comment on, assign, and transition issues in the future, you're welcome to create a Jira account! It makes things a bit easier for us on the organizational side if the Full Name on your Jira account either closely matches the name you'd like us to credit in the release notes or includes it in parentheses, e.g. "Nickname (CREDIT NAME)."
Once you've done that (or if you've already done it -- Jira has been unreliable about showing us new accounts in the admin panel lately), you can either reply here or send an email to otw-coders@transformativeworks.org with your account name and email address and we'll set up the permissions for you.
Thanks again for contributing! If you have any questions, you can contact us at the same email address listed above.
| it_behaves_like "an action only authorized admins can access", authorized_roles: read_roles | ||
| end | ||
|
|
||
| context "as nonexistent user" do |
There was a problem hiding this comment.
This should probably be "for a nonexistent user" -- when we say "as [something]", we usually mean the person trying to access the page (e.g., "as admin" means trying to access a preferences page while logged in as an admin).
There was a problem hiding this comment.
The phrasing has been fixed! Here's the email adress to use to find the Jira account : celine.bertaud0@gmail.com
There was a problem hiding this comment.
Thanks for making the fix! Your Jira account permissions should be all set next time you log in.
2 participants
Pull Request Checklist
as the first thing in your pull request title (e.g.
AO3-1234 Fix thing)until they are reviewed and merged before creating new pull requests.
Issue
https://otwarchive.atlassian.net/browse/AO3-7267
Purpose
What does this PR do?
When a user or admin visits the preferences page of a nonexistent user, they are redirected to the "Not Found" page.
Users who are logged in can still access their own preferences page.
Credit
What name and pronouns should we use to credit you in the Archive of Our Own's Release Notes?
Céline Bertaud she/her