Repository navigation
made some changes to database naming - #43
thatgirlginger wants to merge 5 commits into
Conversation
|
for additional bug info and steps to reproduce: the issue was happening while running Debian 13 (Trixie) and MacOS Sequoia 15.7.7. all logs are from the MacOS runs, as my CPU temperatures on Debian currently handle the eFiction processor rather poorly running the eFiction converter as instructed in the README produced this error in Step 01: after wrapping the offending line (122 in opendoors/mysql.py) in a try/except block, the program would crash while attempting to load the step's information into the database as such: according to the MySQL 8.4 reference docs, most identifier types are limited at 64 characters (https://dev.mysql.com/doc/refman/8.4/en/identifier-length.html) attached is an abbreviated and PII-redacted version of the log file. |
hlieberman
left a comment
There was a problem hiding this comment.
Talked this over with the contributor; the underlying issue is improper validation of the codename attribute in start.py.
changed the way databases are named in MySQL from using their full filepaths to just the end. I added a new function to opendoors/utils.py to create a second variable from the full filepath, since it seemed in most cases that file paths and database names were being used in two distinct stages anyways, and swapped the variable out for the creation of the database
i also reconciled the file naming between the original and simplified steps. the original sequence was adding the prefix onto the edited file name created in the class initialization, but this was essentially creating an uber-nested backup for the first eFiction step
also made minor copyedits in the README; instructions indicated python3, but the examples for command line used python, so changed to python3