Skip to content

Added feature for story cleaning - #92

Open
thatgirlginger wants to merge 4 commits into
otwcode:masterfrom
thatgirlginger:master
Open

thatgirlginger wants to merge 4 commits into
otwcode:masterfrom
thatgirlginger:master

Conversation

@thatgirlginger

Copy link
Copy Markdown

cleaned and added feature for aid in story cleaning with custom archives where notes and summaries might be in the main body of text

@hlieberman hlieberman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely will be a help on some of the non-EF imports.

Comment thread story_cleanup/keywords.py
@@ -0,0 +1,72 @@
class Keywords:
def __init__(self):
self.notes = [

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than list all combinations of cases, we could do a case-insensitive match later.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can definitely do that.

i was also thinking about adding another config argument with more specific keywords, since this is one of those things that can vary a lot between archives. (in my own branch the notes keyword list alone has doubled).

do you think adding additional optional info in the YAML for this case would be ideal? i don't want anything to get too confusing or too bulky, but i also don't want to make the configuration too confusing

Comment thread story_cleanup/messages.py
@@ -0,0 +1,50 @@
from colorama import Fore, Style

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new library to this repo, so it needs to be added to the requirements.txt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants