Fix falsy string values like "0" being treated as empty#7
Open
Fix falsy string values like "0" being treated as empty#7
Conversation
getValueAsString() used ?: (falsy check) instead of ?? (null coalescing), causing string "0" to return the default value. hasValue() used !empty() which also treats "0" as empty. Both now correctly handle all non-null values. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getValueAsString()used?:(falsy check) instead of??(null coalescing), causing the string"0"to return$default(null) instead of"0"hasValue()used!empty($value)which also treats"0"as empty in PHP, causinggetValue()to return the default as wellTest plan
test_falsy_string_valuesthat creates a setting with value"0"and assertshasValue(),setting(),settingAsString(), andgetValueAsString()all return the correct value🤖 Generated with Claude Code