Repository navigation
packagemanager: downloads extract again on Windows - #2365
Merged
Merged
Conversation
Bumps zipdownloader: the downloaded archive was still held by its QTemporaryFile when miniz tried to open it, so the user library and every package failed with "The downloaded archive could not be read". Entries are also extracted past MAX_PATH now.
|
coverage: 49.18% (-0.003%) from 49.183% — packagemanager-windows-zip into master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows the package manager could not install anything downloaded as a zip: the first-run user library download,
installAddon,installLibraryandinstallSDKall failed with "The downloaded archive could not be read".This bumps
3rdparty/zipdownloaderto jcelerier/zipdownloader#6, which has the details:QTemporaryFilewhen miniz tried to open it, and miniz's_wfopen_srefuses to share a file with a writer. The temporary file is now released first.QFile, so paths pastMAX_PATHextract. The user library's deepest entry is 169 characters before the packages folder, close to the limit for a long user name or a OneDrive-redirected Documents folder.Merge jcelerier/zipdownloader#6 first. The submodule commit (
a7ed5dd) currently exists only on that PR's branch; if that branch is squash-merged or rebased, this bump needs to point at the resulting commit.Testing
Windows 11, clang64:
score_lib_basebuilds in the developer configuration. A standalone harness over the same sources downloads and extractsscore-user-library/archive/master.zipin Release (6741 files) where it failed before. The full score application has not been run with this change.