fix(pkpass): create PKPass passType column on fresh install - #727
Merged
Merged
Conversation
PKPass.passType only existed via the addPassType migration, but an unguarded ADD COLUMN (sourceSize) collided with createTables on fresh installs and aborted the whole migration loop, so addPassType never ran. Route every ADD COLUMN through an idempotent addColumn guard, declare the full current schema in each createTables, and on a fresh database record migrations as applied instead of replaying them. Dedup the search-column backfill. Refs #725 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
table PKPass has no column named passType, [BUG] Error while importing passkey #725) and on importing an image (table Page has no column named qrcode, [BUG] Sqlite error when importing image #722). Root cause is shared: an unguardedADD COLUMN(sourceSize) collided withcreateTableson fresh installs and threw, aborting the whole migration loop before the laterADD COLUMNmigrations (qrcode,colors,pkpass_id,passType) ran.ADD COLUMNthrough an idempotent guard so one already-applied column can never abort the migration sequence again.createTablesdeclare the full current schema (all columns + indexes); on a brand new database, record migrations as applied instead of replaying history.Testing
npx eslint app/services/documents.ts— clean;yarn svelte-check— 0 errors.Refs #725
Refs #722