Replace geometry check trigger by WHERE condition on COPY - #2500
Merged
Conversation
Since version 12 PostgreSQL supports a WHERE condition on the
COPY command. Use this to add a geometry check when adding data
to the database instead of the trigger we used before.
This makes the code simpler and doesn't clutter the database with
triggers.
If you have already imported a database with an older version of
osm2pgsql and want to use this new version, that will still work. But
the original triggers will still be there so there is some extra work
done for each update. Simply remove the triggers and trigger functions
from the database with commands of the form
DROP TRIGGER *_osm2pgsql_valid ON *;
DROP FUNCTION *_osm2pgsql_valid;
PostgreSQL 12 is currently the oldest database version we support.
This also makes the version of the proj library osm2pgsql was compiled
with available in the Lua config as the "osm2pgsql.proj_version" string
variable. It is set to '[disabled]' if osm2pgsql was compiled without
proj support. It is needed for this so we can disable the test if proj
is not available.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since version 12 PostgreSQL supports a WHERE condition on the COPY command. Use this to add a geometry check when adding data to the database instead of the trigger we used before.
This makes the code simpler and doesn't clutter the database with triggers.
If you have already imported a database with an older version of osm2pgsql and want to use this new version, that will still work. But the original triggers will still be there so there is some extra work done for each update. Simply remove the triggers and trigger functions from the database with commands of the form
DROP TRIGGER *_osm2pgsql_valid ON *;
DROP FUNCTION *_osm2pgsql_valid;
PostgreSQL 12 is currently the oldest database version we support.