Repository navigation
Align Lyo acceptance builds and weekly dependency updates - #629
Merged
Merged
Conversation
Signed-off-by: Andrii Berezovskyi <andriib@kth.se>
Signed-off-by: Andrii Berezovskyi <andriib@kth.se>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The manual Lyo acceptance workflow now defaults to
eclipse-lyo/lyoonmain, installs the selected checkout, detects its Maven version, and passes that version to all three host Maven project builds. Remove redundant oslc-domains and trs-client dependency versions so the imported BOM manages them, including during the override.Keep RefImpl's normal default on
7.0.0-SNAPSHOT. The four server modules already referenceorg.eclipse.lyo.server:lyo-server-common, matching the corrected upstream publication and BOM. Keep Lyo version properties in their original locations outside the user-code regions.Skip upstream test compilation/execution, Javadocs, source JARs, CycloneDX output, and the SpotBugs/Spotless/Enforcer profiles. Change Dependabot updates to weekly and comment out the scheduled wide acceptance run. Main CI was already unscheduled. Pin the manual workflow's action references, restrict permissions to read-only, and disable checkout credential persistence. Container publication schedules and DEVELOPMENT.md are unchanged.
Validation:
mvn -B --no-transfer-progress test --file src/pom.xmlpassed all seven reactor modules with the snapshot default, including resolution oforg.eclipse.lyo.server:lyo-server-common.version.lyoconfirmed that all 272 Lyo dependency entries follow the override; this was a model check, not a Beta4 build.actionlint -shellcheck= -pyflakes=passed across workflows; offline zizmor reported no findings for the manual acceptance workflow using the existing suppressions.git diff --checkpassed validation.Docker acceptance tests were not run locally. Existing Dockerfiles perform separate Maven builds and do not consume the host's local Lyo installation or command-line override; this PR updates the host Maven invocations without changing that existing container build behavior.
After removing the redundant dependency versions, Maven effective-POM comparison confirmed that resolved dependency versions, scopes, types, and classifiers are unchanged. The BOM import retains its required version.