Repository navigation
Validate RM requirements on POST and PUT using lyo-validation - #614
Open
berezovskyi wants to merge 2 commits into
Open
berezovskyi wants to merge 2 commits into
berezovskyi wants to merge 2 commits into
Conversation
github-actions
Bot
force-pushed
the
berezovskyi/add-rm-requirement-validation-on-post-put-using
branch
from
October 20, 2026 12:55
7671a69 to
f52f948
Compare
berezovskyi
commented
Nov 1, 2026
| import org.eclipse.lyo.shacl.ValidationReport; | ||
|
|
||
| /** A validation result; the report is absent when the resource itself is null. */ | ||
| public record ValidatedResource<T extends AbstractResource>(T resource, boolean valid, ValidationReport report) { |
Member
Author
There was a problem hiding this comment.
Candidate for upstreaming to lyo-validation
| import org.eclipse.lyo.shacl.ValidationReport; | ||
| import org.eclipse.lyo.validation.ValidatorFactory; | ||
|
|
||
| public final class RequirementValidation { |
Member
Author
There was a problem hiding this comment.
Candidate for upstreaming to lyo-server-common or other server capability. Also good to consider a Jakarta prodivider for ValidatedResource<T> where a REST handler method does not need to do validation manually.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #179
Testing
cd src && mvn test -pl server-rm -am -Denforcer.skip=true(12 RM tests).mvn test -Denforcer.skip=truebefore the final summary-method refactor; targeted tests rerun after it.mvn testis blocked by an existing SLF4J upper-bound conflict (slf4j-api 2.0.19 vs slf4j-simple 2.0.20); no unrelated dependency changes included.