Repository navigation
Document that transported release pins win - #318
Merged
Merged
Conversation
ideaship
force-pushed
the
readme-release-pin-precedence
branch
from
October 5, 2026 05:14
8e24382 to
4a73bba
Compare
The README called these files "defaults only" and named the operator's inventory, host_vars and extra-vars as the only layer overriding them. That is no longer the whole picture: the runner images (kolla-ansible, ceph-ansible, osism-ansible, osism-kubernetes) also deliver release-specific values into the inventory, as group_vars/all/100-versions-<runner>.yml. Those files sort after every file in this repo, so they override it too. osism-ansible now delivers the image tags of OSISM's own services this way (https://github.com/osism/container-image-osism-ansible), so a maintainer default here can no longer be assumed to be the value that actually deploys. Document the resulting precedence: maintainer defaults here, beaten by the transported release values, beaten in turn by the operator. Spell out where the operator's override reliably wins: the documented environments/<env>/images.yml (and the other environments/<env>/*.yml extra-vars files), and inventory group_vars/<group> or host_vars, which sit outside group_vars/all and so win regardless of file name. A file the operator drops directly into group_vars/all is not reliable the same way: it beats the release only if its name sorts after 100-versions-osism-kubernetes.yml, the last runner file (a name starting with a letter does); a numeric prefix such as 050-*.yml loses to the release, the same as this repo's own files. A flat group_vars/all.yml is moved to group_vars/all/999-all.yml and wins. State the rule that follows: a tag set in this repo loses to a transported release value, so a version value here is either an explicit exception for a key the release does not transport, or a fallback for a track on which no runner transports it, as ceph_image_version is for the latest track. List the stated role-managed exceptions: kepler, httpd and httpd_data, homer and nexus, and the zuul CI stack. List what each runner's versions.yml carries, including the Ceph pins that osism-ansible delivers in numbered releases (ceph_image_version and cephclient_version, selected by ceph_version). Note that the osism/release drift detector reads ceph-ansible and osism-kubernetes only for their playbooks, so a value that only their versions.yml transports is outside its coverage. Correct the 002-images-ceph.yml entry: ceph_image_version is no longer only supplied externally, since it defaults to ceph_version here and release pins override it. Documentation only; no deployed value changes. Assisted-by: Claude:claude-sonnet-5 Assisted-by: Claude:claude-opus-5-5 Signed-off-by: Roger Luethi <luethi@osism.tech>
ideaship
force-pushed
the
readme-release-pin-precedence
branch
from
October 7, 2026 16:51
4a73bba to
bcededb
Compare
ideaship
marked this pull request as ready for review
October 9, 2026 18:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The README called these files "defaults only" and named the
operator's inventory, host_vars and extra-vars as the only layer
overriding them. That is no longer the whole picture: the runner
images (kolla-ansible, ceph-ansible, osism-ansible,
osism-kubernetes) also deliver release-specific values into the
inventory, as group_vars/all/100-versions-.yml. Those files
sort after every file in this repo, so they override it too.
osism-ansible now delivers the image tags of OSISM's own services
this way (https://github.com/osism/container-image-osism-ansible),
so a maintainer default here can no longer be assumed to be the
value that actually deploys.
Document the resulting precedence: maintainer defaults here, beaten
by the transported release values, beaten in turn by the operator.
Spell out where the operator's override reliably wins: the
documented environments//images.yml (and the other
environments//.yml extra-vars files), and inventory
group_vars/ or host_vars, which sit outside group_vars/all
and so win regardless of file name. A file the operator drops
directly into group_vars/all is not reliable the same way: it beats
the release only if its name sorts after
100-versions-osism-kubernetes.yml, the last runner file (a name
starting with a letter does); a numeric prefix such as 050-.yml
loses to the release, the same as this repo's own files. A flat
group_vars/all.yml is moved to group_vars/all/999-all.yml and wins.
State the rule that follows: a tag set in this repo loses to a
transported release value, so a version value here is either an
explicit exception for a key the release does not transport, or a
fallback for a track on which no runner transports it, as
ceph_image_version is for the latest track. List the stated
role-managed exceptions: kepler, httpd and httpd_data, homer and
nexus, and the zuul CI stack.
List what each runner's versions.yml carries, including the Ceph pins
that osism-ansible delivers in numbered releases (ceph_image_version
and cephclient_version, selected by ceph_version). Note that the
osism/release drift detector reads ceph-ansible and osism-kubernetes
only for their playbooks, so a value that only their versions.yml
transports is outside its coverage. Correct the 002-images-ceph.yml
entry: ceph_image_version is no longer only supplied externally, since
it defaults to ceph_version here and release pins override it.
Documentation only; no deployed value changes.
Part of:
🤖 Generated with Claude Code