Skip to content

Document that transported release pins win - #318

Merged
berendt merged 1 commit into
mainfrom
readme-release-pin-precedence
Oct 9, 2026
Merged

berendt merged 1 commit into
mainfrom
readme-release-pin-precedence

Conversation

@ideaship

@ideaship ideaship commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor

The README called these files "defaults only" and named the
operator's inventory, host_vars and extra-vars as the only layer
overriding them. That is no longer the whole picture: the runner
images (kolla-ansible, ceph-ansible, osism-ansible,
osism-kubernetes) also deliver release-specific values into the
inventory, as group_vars/all/100-versions-.yml. Those files
sort after every file in this repo, so they override it too.
osism-ansible now delivers the image tags of OSISM's own services
this way (https://github.com/osism/container-image-osism-ansible),
so a maintainer default here can no longer be assumed to be the
value that actually deploys.

Document the resulting precedence: maintainer defaults here, beaten
by the transported release values, beaten in turn by the operator.
Spell out where the operator's override reliably wins: the
documented environments//images.yml (and the other
environments//.yml extra-vars files), and inventory
group_vars/ or host_vars, which sit outside group_vars/all
and so win regardless of file name. A file the operator drops
directly into group_vars/all is not reliable the same way: it beats
the release only if its name sorts after
100-versions-osism-kubernetes.yml, the last runner file (a name
starting with a letter does); a numeric prefix such as 050-
.yml
loses to the release, the same as this repo's own files. A flat
group_vars/all.yml is moved to group_vars/all/999-all.yml and wins.

State the rule that follows: a tag set in this repo loses to a
transported release value, so a version value here is either an
explicit exception for a key the release does not transport, or a
fallback for a track on which no runner transports it, as
ceph_image_version is for the latest track. List the stated
role-managed exceptions: kepler, httpd and httpd_data, homer and
nexus, and the zuul CI stack.

List what each runner's versions.yml carries, including the Ceph pins
that osism-ansible delivers in numbered releases (ceph_image_version
and cephclient_version, selected by ceph_version). Note that the
osism/release drift detector reads ceph-ansible and osism-kubernetes
only for their playbooks, so a value that only their versions.yml
transports is outside its coverage. Correct the 002-images-ceph.yml
entry: ceph_image_version is no longer only supplied externally, since
it defaults to ceph_version here and release pins override it.

Documentation only; no deployed value changes.

Part of:

🤖 Generated with Claude Code

The README called these files "defaults only" and named the
operator's inventory, host_vars and extra-vars as the only layer
overriding them. That is no longer the whole picture: the runner
images (kolla-ansible, ceph-ansible, osism-ansible,
osism-kubernetes) also deliver release-specific values into the
inventory, as group_vars/all/100-versions-<runner>.yml. Those files
sort after every file in this repo, so they override it too.
osism-ansible now delivers the image tags of OSISM's own services
this way (https://github.com/osism/container-image-osism-ansible),
so a maintainer default here can no longer be assumed to be the
value that actually deploys.

Document the resulting precedence: maintainer defaults here, beaten
by the transported release values, beaten in turn by the operator.
Spell out where the operator's override reliably wins: the
documented environments/<env>/images.yml (and the other
environments/<env>/*.yml extra-vars files), and inventory
group_vars/<group> or host_vars, which sit outside group_vars/all
and so win regardless of file name. A file the operator drops
directly into group_vars/all is not reliable the same way: it beats
the release only if its name sorts after
100-versions-osism-kubernetes.yml, the last runner file (a name
starting with a letter does); a numeric prefix such as 050-*.yml
loses to the release, the same as this repo's own files. A flat
group_vars/all.yml is moved to group_vars/all/999-all.yml and wins.

State the rule that follows: a tag set in this repo loses to a
transported release value, so a version value here is either an
explicit exception for a key the release does not transport, or a
fallback for a track on which no runner transports it, as
ceph_image_version is for the latest track. List the stated
role-managed exceptions: kepler, httpd and httpd_data, homer and
nexus, and the zuul CI stack.

List what each runner's versions.yml carries, including the Ceph pins
that osism-ansible delivers in numbered releases (ceph_image_version
and cephclient_version, selected by ceph_version). Note that the
osism/release drift detector reads ceph-ansible and osism-kubernetes
only for their playbooks, so a value that only their versions.yml
transports is outside its coverage. Correct the 002-images-ceph.yml
entry: ceph_image_version is no longer only supplied externally, since
it defaults to ceph_version here and release pins override it.

Documentation only; no deployed value changes.

Assisted-by: Claude:claude-sonnet-5
Assisted-by: Claude:claude-opus-5-5
Signed-off-by: Roger Luethi <luethi@osism.tech>
@ideaship
ideaship force-pushed the readme-release-pin-precedence branch from 4a73bba to bcededb Compare October 7, 2026 16:51
@ideaship
ideaship marked this pull request as ready for review October 9, 2026 18:11
@ideaship
ideaship requested a review from berendt October 9, 2026 18:11
@berendt
berendt merged commit c84239b into main Oct 9, 2026
2 checks passed
@berendt
berendt deleted the readme-release-pin-precedence branch October 9, 2026 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants