Repository navigation
Retire kolla-operations - #311
Merged
Merged
Conversation
Retire kolla-operations at 2025.1 and later. The flag becomes truthy only for 2024.1 and 2024.2, so the /operations entries drop out of the six *_paths search lists everywhere else. The feature already delivered nothing at 2025.1+. Its six *_paths keys only mean anything with kolla-operations.patch, which teaches the upstream grafana and prometheus roles to read path lists instead of a single hard-coded node_custom_config directory. That patch arrived .disabled at 2025.1 in container-image-kolla-ansible because it had stopped applying, and is absent at 2026.1. Upstream has no counterpart for any of the six variables at stable/2025.1, stable/2025.2, stable/2026.1 or master, so they are inert there. This change states that explicitly rather than leaving a flag that reads as enabled while doing nothing. Gated rather than deleted. all/ is release-independent and defaults is fetched fresh at deploy time, so removing the keys would immediately strip the Grafana dashboards and Prometheus alert rules from 2024.1, which is a SLURP release and still deployable. 2024.1 is the last place any deployment still receives them. The six *_paths keys are left unchanged. They are still consumed at 2024.1 and 2024.2, and with the flag false their /operations branches evaluate away on their own. Naming the two legacy releases explicitly, rather than excluding 2026.1, means every future release inherits the retirement without a further edit. The drift-allowlist entries in osism/release stay for now: the keys still exist, so kolla_retired_patch_orphan still reports them. They are removed together with the keys once 2024.1 and 2024.2 are retired. Assisted-by: Claude:claude-opus-5 Signed-off-by: Roger Luethi <luethi@osism.tech>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gates
enable_kolla_operationstoopenstack_version in ['2024.1', '2024.2'], the only releases wherekolla-operations.patchstill applies. Everywhere else the/operationsentries drop out of the six*_pathssearch lists.This is a cleanup, not a feature removal. The six
*_pathskeys only mean anything with that patch, which teaches the upstream grafana and prometheus roles to read path lists instead of one hard-codednode_custom_configdirectory. The patch arrived.disabledat 2025.1 because it had stopped applying, and is absent at 2026.1, so from 2025.1 on these keys have had no consumer — upstream defines none of the six atstable/2025.1,stable/2025.2,stable/2026.1ormaster. The flag has been reading as enabled while doing nothing.Gated rather than deleted, because
all/is release-independent anddefaultsis fetched fresh at deploy time. Removing the keys would immediately strip the Grafana dashboards and Prometheus alert rules from 2024.1 — unmaintained upstream, but still supported by OSISM, and the last place any deployment still receives them. The six keys are therefore left untouched; with the flag false their/operationsbranches evaluate away on their own.Naming the two legacy releases explicitly, rather than excluding 2026.1, means every future release inherits the retirement with no further edit.
The
drift-allowlist.ymlentries inosism/releasestay for now — the keys still exist, sokolla_retired_patch_orphanstill reports them. They come out together with the keys once 2024.1 and 2024.2 are retired.Part of a cross-repo effort. Background, the full change set and what is deliberately not changed:
🤖 Generated with Claude Code