Skip to content

build(deps)!: update reqwest and remove rustls TLS feature#8

Open
Havunen wants to merge 1 commit into
ory:masterfrom
Havunen:feat/update_reqwest
Open

build(deps)!: update reqwest and remove rustls TLS feature#8
Havunen wants to merge 1 commit into
ory:masterfrom
Havunen:feat/update_reqwest

Conversation

@Havunen
Copy link
Copy Markdown

@Havunen Havunen commented May 25, 2026

BREAKING CHANGE: The rustls-tls Cargo feature was removed; only native-tls is exposed.

  • update reqwest to 0.13 with query and form support
  • bump serde_with and uuid dependency ranges
  • refresh Cargo.lock
  • ignore JetBrains .idea files

Related Issue or Design Document

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact security@ory.com) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

Summary by CodeRabbit

  • Chores

    • Updated development configuration files
  • Dependencies

    • Updated library versions: serde_with (3.8 → 3.20), uuid (1.8 → 1.23), reqwest (0.12 → 0.13)
    • Extended reqwest with query and form request support
    • Removed rustls-tls feature; TLS support now available exclusively through native-tls

Review Change Stack

  BREAKING CHANGE: The rustls-tls Cargo feature was removed; only native-tls is exposed.

  - update reqwest to 0.13 with query and form support
  - bump serde_with and uuid dependency ranges
  - refresh Cargo.lock
  - ignore JetBrains .idea files
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 25, 2026

📝 Walkthrough

Walkthrough

This PR updates Rust dependencies for the ory-client crate and adds IDE configuration to .gitignore. Dependency versions are bumped for serde_with, uuid, and reqwest; reqwest gains query and form features. The public rustls-tls crate feature is removed while native-tls remains.

Changes

Maintenance and Dependency Updates

Layer / File(s) Summary
IDE configuration ignore
.gitignore
.idea directory is added to .gitignore to exclude JetBrains IDE project files.
Dependency versions and feature updates
Cargo.toml
Dependency versions bumped: serde_with ^3.8 → ^3.20, uuid ^1.8 → ^1.23, reqwest ^0.12 → ^0.13 with query and form features added. The public rustls-tls crate feature is removed; native-tls feature remains.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The PR description includes a clear breaking change notice and itemized changes, but lacks detailed context for why these updates are necessary and does not reference a design document or related issue as required by the template for feature work. Add a reference to a design document or related issue explaining the rationale for these dependency updates, and provide more context about the implications of removing the rustls-tls feature.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main changes: updating reqwest and removing the rustls-tls feature, with the breaking change indicator (!) appropriately used.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Havunen
Copy link
Copy Markdown
Author

Havunen commented May 25, 2026

@aeneasr Can you review this change, I would like to move to latest version of reqwest.

Thanks, Havunen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant