Repository navigation
fix: resolve vulnerabilities reported by the Docker image scan - #467
Merged
Merged
Conversation
Upgrade all installed Alpine packages in the runtime images instead of only libssl3/libcrypto3. The alpine base images lag behind the package repositories; zlib 1.3.2-r1 (CVE-2026-4738, critical) fails the scan although 1.4-r0 is already available for both 3.22 and 3.24. Bump Go modules to their first patched versions: - google.golang.org/grpc v1.83.2 (GHSA-2v4p-qf9q-27wj) - github.com/getkin/kin-openapi v0.149.0 (GHSA-rj39-cv6w-8wv7, GHSA-g8cf-rcjf-c8cf, GHSA-vrcc-3ch7-hppw) - golang.org/x/net v0.62.0 (GO-2026-6860, GO-2026-6866) - golang.org/x/crypto v0.59.0 (GO-2026-5932) github.com/go-jose/go-jose/v3 has no patched v3 release; it is still linked through ory/hydra/v2/cmd and ory/x/jwksx, which both pin v3 on master. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DUBUDtBsoC8hPjW2z7atVc
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 9 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Docker image scan passes again. The runtime images now upgrade all installed Alpine packages, and the vulnerable Go modules are bumped to their first patched versions.
.docker/Dockerfile-build(the image the scan checks) and.docker/Dockerfile-alpine(the-alpinerelease images) runapk upgrade --no-cacheinstead of upgrading onlylibssl3/libcrypto3.google.golang.org/grpcv1.83.2 (GHSA-2v4p-qf9q-27wj)github.com/getkin/kin-openapiv0.149.0 (GHSA-rj39-cv6w-8wv7, GHSA-g8cf-rcjf-c8cf, GHSA-vrcc-3ch7-hppw)golang.org/x/netv0.62.0 (GO-2026-6860, GO-2026-6866)golang.org/x/cryptov0.59.0 (GO-2026-5932)Only
golang.org/x/*modules moved along with these; noory/*modules changed.Related Issue or Design Document
The
dockerjob of the Docker Image Scan fails on findings rated critical, such as in https://github.com/ory/cli/actions/runs/43060567941/job/130661697455?pr=466. The critical finding is zlib 1.3.2-r1 (CVE-2026-4738) from the Alpine base image. zlib 1.4-r0 is already in the Alpine 3.22 and 3.24 repositories, but the base images have not been rebuilt with it, and the Dockerfiles upgraded only the OpenSSL libraries.Both images, scanned with grype v0.110.0 and the flags of the workflow, now exit 0 and contain zlib 1.4-r0.
ory dev openapi migrate, which uses kin-openapi and has no tests, produces byte-identical output before and after the bump.The scan still reports two findings without a fix; neither fails the job:
github.com/go-jose/go-jose/v3(GHSA-mgcc-cww5-fp2q, GHSA-vvm8-gf78-28g4, GHSA-4w3g-jfj2-cw2q): there is no patched v3 release, only v4 ≥ 4.1.6. Besidescmd/cloudx/proxy,ory/hydra/v2/cmdandory/x/jwksxlink v3, and both pin v3.0.5 on master, so clearing it needs ory/x and hydra to move to v4 first.Checklist
and signed the CLA.
introduces a new feature.
vulnerability. If this pull request addresses a security vulnerability, I
confirm that I got approval (please contact
security@ory.com) from the maintainers to push
the changes.
works.
appropriate).
🤖 Generated with Claude Code
https://claude.ai/code/session_01DUBUDtBsoC8hPjW2z7atVc