Skip to content

test: keep TestCommandHelper fixtures intact for parallel subtests #465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alnr merged 1 commit into from
Nov 4, 2026
Merged

test: keep TestCommandHelper fixtures intact for parallel subtests #465

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions cmd/cloudx/client/command_helper_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,8 @@ func TestCommandHelper(t *testing.T) {

email, password, name := testhelpers.RegisterAccount(ctx, t)

// Parallel subtests log in through this browser, so it may only be closed
// once all of them have finished, which is when t.Cleanup runs.
browser, page, cleanup := testhelpers.SetupPlaywright(t)
t.Cleanup(cleanup)
authenticated, err := client.NewCommandHelper(
Expand Down Expand Up @@ -87,6 +89,8 @@ func TestCommandHelper(t *testing.T) {

t.Run("func=SelectProjectWorkspace", func(t *testing.T) {
t.Parallel()
// Selecting rewrites the config file, which the parallel subtests share.
ctx, _ := testhelpers.WithDuplicatedConfigFile(ctx, t, defaultConfigFile)
h, err := client.NewCommandHelper(ctx)
require.NoError(t, err)
otherWorkspace, err := h.CreateWorkspace(ctx, "other workspace")
Expand Down Expand Up @@ -237,9 +241,6 @@ func TestCommandHelper(t *testing.T) {
require.NoError(t, h.Authenticate(ctx))
t.Logf("authentication successful")

// we don't need playwright anymore
cleanup()

// assert success
config, err := h.GetAuthenticatedConfig(ctx)
require.NoError(t, err)
Expand Down
Loading