⚡ Bolt: Optimize HashSet away in emit_sla_alerts - #117
Conversation
Replaces the `HashSet` used for deduplicating SLA alerts during the scheduler execution hot path with a zero-allocation sorted `Vec` and `binary_search`. This avoids both heap allocation for bucket arrays and hashing overhead when checking bounds, streamlining the loop. Derived PartialOrd and Ord on `InstanceId` to support sorting by tuple. Co-authored-by: ovasylenko <3797513+ovasylenko@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
💡 What: Replaced the
std::collections::HashSetinsideemit_sla_alertswith a sortedVecof references and abinary_search. DerivedPartialOrdandOrdforInstanceIdinorch8-types.🎯 Why: Creating and populating a
HashSeton every tick insideemit_sla_alertsintroduces unnecessary heap allocation and hashing overhead on the execution hot path. Using a pre-sorted vector of tuple references(&InstanceId, &BlockId)avoids these allocations and speeds up the exclusion check.📊 Impact: Reduces heap allocations and CPU cycles spent on hashing during scheduler SLA sweeps, particularly when batch processing many candidate breaches.
🔬 Measurement: Verified via
cargo +nightly test -p orch8-engineto ensure no changes to alert emission semantics, and ran formatting/lint checks.PR created automatically by Jules for task 2310308191572356091 started by @ovasylenko