fix(desktop): abort repos fetch on unmount + retry transient rate limits#168
Merged
Conversation
… limits Two robustness fixes for the GitHub dialog's fetches: - The "Your repositories" fetch had no AbortController, so closing the dialog before it resolved updated stale state (and the spinner could flip after unmount). It now aborts on unmount and when superseded, and only the latest request owns the loading spinner. - New ghFetch() wrapper retries once on GitHub's *secondary* (abuse) rate limit — 403/429 with a short Retry-After (≤ 8s) — used by openFile/enterDir/loadRepos. A *primary* rate limit (no/far Retry-After) still surfaces as an error with the sign-in hint rather than hanging. tsc ✓ · vitest (3) ✓ · biome ✓ · build ✓. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The last two GitHub-dialog backlog items.
AbortController, so closing the dialog mid-fetch updated stale state and could flip the spinner after unmount. It now aborts on unmount and when superseded, and only the latest request owns the loading spinner.ghFetch()wrapper retries once on GitHub's secondary (abuse) rate limit —403/429with a shortRetry-After(≤ 8 s) — used by openFile / enterDir / loadRepos. A primary rate limit (no / far-futureRetry-After) still surfaces as an error with the sign-in hint instead of hanging.tsc✓ ·vitest(3) ✓ ·biome✓ ·build✓.🤖 Generated with Claude Code