Skip to content

fix(ios): clearer error for a too-large (Zip64) repository #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
oratis merged 1 commit into from
Jun 14, 2026
Merged

fix(ios): clearer error for a too-large (Zip64) repository #166

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions ios/MarkupApp/MarkupApp/GitHubService.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ final class GitHubService {
static let shared = GitHubService()

enum GitHubError: LocalizedError {
case notAFile, rateLimited, forbidden, notFound, http(Int), badURL, badArchive
case notAFile, rateLimited, forbidden, notFound, http(Int), badURL, badArchive, repoTooLarge
var errorDescription: String? {
switch self {
case .notAFile: return "That link points to a folder, not a file."
Expand All @@ -19,6 +19,8 @@ final class GitHubService {
case .http(let c): return "GitHub request failed (HTTP \(c))."
case .badURL: return "Couldn't build the request URL."
case .badArchive: return "Couldn't read the repository archive."
case .repoTooLarge:
return "This repository is too large to open as a vault (over 4 GB). Try opening a sub-folder instead."
}
}
}
Expand Down Expand Up @@ -331,7 +333,9 @@ final class GitHubService {
nonisolated static func extractZipball(_ data: Data, to root: URL) throws {
// Fail loudly on zip64 rather than open a silently-incomplete vault:
// ZipArchive can't parse it and would drop entries with no error.
if ZipArchive.isLikelyZip64(data) { throw GitHubError.badArchive }
// Zip64 (> 4 GB) — ZipArchive can't parse it and would silently drop
// entries; surface a clear "too large" message rather than a generic one.
if ZipArchive.isLikelyZip64(data) { throw GitHubError.repoTooLarge }
let entries = ZipArchive.extract(data)
guard let top = GitHubZipball.topLevelDir(entries.map(\.path)) else {
throw GitHubError.badArchive
Expand Down
Loading