fix(desktop): inline "Sign in" on private-repo / rate-limit errors#163
Merged
Conversation
…errors A private repo (or a hit rate limit) while signed out produced a dead-end red error in the GitHub dialog — the user had to know that signing in was the fix. Now the message is signed-in-aware and, when signing in would help, an inline "Sign in" button sits right next to the error: - 404 signed out → "Not found — if it's a private repo, sign in first." + Sign in - 403 signed out → "GitHub rate limit reached — sign in to raise it." + Sign in - 401 → "Sign-in expired — please sign in again." + Sign in - signed-in 404/403 stay plain (no false sign-in nudge). classifyHttp() replaces httpError(); failWith()/clearError() drive an authHint. tsc ✓ · vitest (3) ✓ · biome ✓ · build ✓. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From the GitHub-vault review backlog. A private repo (or a hit rate limit) while signed out showed a dead-end red error — the user had to know that signing in was the fix.
Now the error is signed-in-aware and, when signing in would help, an inline "Sign in" button sits next to it:
404signed out → "Not found — if it's a private repo, sign in first." + Sign in403signed out → "GitHub rate limit reached — sign in to raise it." + Sign in401→ "Sign-in expired — please sign in again." + Sign in404/403stay plain (no false nudge).classifyHttp()replaceshttpError();failWith()/clearError()drive anauthHint.tsc✓ ·vitest(3) ✓ ·biome✓ ·build✓.🤖 Generated with Claude Code