chore(deps): bump the testing and misc-runtime groups - #161
Merged
Merged
Conversation
Combines dependabot groups #155 (testing) and #122 (misc-runtime) onto a single branch, since both were blocked on the same CI job. Testing (#155): - @playwright/test 1.55.0 -> 1.63.0 - @testing-library/dom 10.4.1 -> 10.4.2 - @vitest/coverage-v8 4.1.11 -> 5.0.0 - vitest 4.1.11 -> 5.0.0 Misc runtime (#122): - @lobehub/icons 5.16.0 -> 5.18.0 - @lobehub/ui 5.35.0 -> 5.47.1 - @simplewebauthn/browser 13.3.0 -> 14.0.0 - @simplewebauthn/server 13.3.3 -> 14.0.2 - antd 6.6.2 -> 6.6.4 - jotai 2.20.3 -> 3.0.0 - lucide-react 1.35.0 -> 1.45.0 - motion 12.42.2 -> 12.43.0 - next-intl 4.14.1 -> 4.14.4 - zod 4.5.2 -> 4.6.5 - @next/eslint-plugin-next 16.3.3 -> 16.3.5 - lint-staged 17.4.1 -> 17.5.1 - postcss 8.5.26 -> 8.5.28 - sass 1.103.1 -> 1.104.1 Three breaking changes needed follow-up fixes: Import jest-dom via its /vitest entry point. The bare entry only augments the global jest namespace, which does nothing here because @types/jest is not installed; vitest 5 narrows Assertion<> in a way that surfaced this, so toBeInTheDocument/toBeVisible/toHaveTextContent were reported as missing in tests/admin/*. Hold motion at 12.x instead of taking #122's 13.2.0. @lobehub/ui 5.47.1 still depends on motion ^12, so 13 installs a second nested copy and `motion` stops being assignable to MotionComponentType (TS2590/TS2322 in app/lobe-ui-provider.tsx and tests/admin/*). Staying on 12 keeps a single hoisted copy. Replace AuthenticatorTransportFuture with a plain string[] for passkey transports. @simplewebauthn/server 14 dropped that type and widened transports to string[]. The values are advisory metadata forwarded between the browser and stored credentials, so mirroring upstream is correct at runtime. Closes #155, closes #122
orangeboyChen
enabled auto-merge (squash)
September 17, 2026 12:51
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #161 +/- ##
==========================================
+ Coverage 95.52% 95.57% +0.05%
==========================================
Files 37 37
Lines 6706 6738 +32
Branches 1933 1944 +11
==========================================
+ Hits 6406 6440 +34
+ Misses 300 298 -2
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Combines dependabot groups #155 (testing) and #122 (misc-runtime) onto one branch — both were blocked on the same
Bun / TypeScript / Coveragejob, and they touch disjoint dependency sets.What failed in the original PRs
Neither PR failed for a trivial reason. The visible CI failure was a red Codecov
test-resultsstep (No JUnit XML reports found), but that was only a downstream symptom:bun run typecheckexits non-zero, sotest:cinever runs and never writestest-report.junit.xml. The real failures were three breaking changes.Fixes
1. jest-dom matcher types (vitest 5)
import '@testing-library/jest-dom'resolves totypes/index.d.ts, which only augments the globaljestnamespace.@types/jestisn't installed here, so those matcher types were never actually applied — vitest 4 tolerated it, vitest 5's narrowerAssertion<>did not, producing 30TS2339errors (toBeInTheDocument,toBeVisible,toHaveTextContent) acrosstests/admin/*.Switched to
@testing-library/jest-dom/vitest, which augments vitest's ownAssertioninterface.2. motion held at 12.x (not #122's 13.2.0)
motion13 is not usable yet:@lobehub/ui5.47.1 (the latest) still declaresmotion: ^12.0.0, so 13 installs a second nested copy.motionthen stops being assignable toMotionComponentType—TS2590+TS2322atapp/lobe-ui-provider.tsx:62and four test files.Bumping to the latest 12.x (12.43.0) keeps a single hoisted copy and typechecks clean.
overridesdid not solve this —@lobehub/uitakes motion as a hard dependency, so I reverted that. Worth re-checking once@lobehub/uisupports motion 13.3.
AuthenticatorTransportFutureremoved (simplewebauthn 14)lib/server/admin/session.tsimported a type that v14 dropped; v14 also widenedtransportsto plainstring[]. Changed the stored field tostring[]. This is correct at runtime, not just type-level: transports are advisory metadata forwarded between the browser and stored credentials.Verification
Full
ci-pr.ymlgate run locally, all green:bun run lintbun run format:checkbun run typecheckbun run test:citest:patch-branchesbun run buildtest-report.junit.xmlis now produced (175 KB, 753 tests), which resolves the Codecov step that was red on both original PRs.Notes
bun.lockdiff is deliberately small (+5/-13): the nested@lobehub/ui/motionentries are removed rather than the whole lockfile being re-resolved through a different registry. Verified reproducible withrm -rf node_modules bun.lock && bun install --frozen-lockfile.bun pm untrustedreports 3 blocked postinstalls (@parcel/watcher,@swc/core,unrs-resolver). These are pre-existing transitive deps of next/eslint, unrelated to this bump.Closes #155
Closes #122