Merge develop into infrahub-develop#947
Merged
ajtmccarty merged 1 commit intoinfrahub-developfrom Apr 14, 2026
Merged
Conversation
The point of upserting an object is to let the API server in charge of deciding what to do. Trying to find if a node is going to be created or updated just for a `print()` seems to be excessive. The node not found error should be raised without needing to call `get` and trigger an API server query/response.
Deploying infrahub-sdk-python with
|
| Latest commit: |
0233b90
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://53fb41b9.infrahub-sdk-python.pages.dev |
| Branch Preview URL: | https://develop.infrahub-sdk-python.pages.dev |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## infrahub-develop #947 +/- ##
====================================================
- Coverage 82.63% 82.36% -0.27%
====================================================
Files 133 134 +1
Lines 13250 13315 +65
Branches 2306 2308 +2
====================================================
+ Hits 10949 10967 +18
- Misses 1652 1702 +50
+ Partials 649 646 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merging develop into infrahub-develop after merging pull request #942.