Add item sharing and public share links#1
Open
Ogglas wants to merge 1 commit into
Open
Conversation
Author
|
@oplane review |
🚨 Oplane Security Review CompleteFound 8 security requirements in this pull request. Unresolved Requirements
Resolved Requirements
Powered by Oplane |
- New ItemShare model for user-to-user sharing with read/edit permissions
- New ShareLink model for token-based public links with optional expiry
- Share/unshare API endpoints under /items/{id}/shares/
- Share link create/list/revoke endpoints under /items/{id}/share-links/
- Public access endpoint GET /shared/{token} with expiry and revocation checks
- Updated items list to include items shared with current user
- Updated item read/update to respect share permissions (read vs edit)
- Alembic migration for itemshare and sharelink tables
- Tests covering sharing, permissions, duplicates, link expiry, and revocation
- Frontend: ShareDialog component with People and Links tabs
- Frontend: Manual axios client for share endpoints
- Frontend: Share action added to item dropdown menu
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
emilkvarnhammar
force-pushed
the
feature/item-sharing
branch
from
1c44576 to
a3a4129
Compare
emilkvarnhammar
changed the title
|
@oplane review |
|
| # | Status | Requirement | Severity |
|---|---|---|---|
| 1 | 🟡 Partially Implemented | Share Link Token Entropy and Uniqueness | Medium |
| 2 | 🔴 Not Implemented | User Enumeration Prevention in Share Endpoints | Low |
Resolved Requirements
| # | Status | Requirement | Severity |
|---|---|---|---|
| 1 | ✅ Implemented | Access Control Enforcement for Shared Item Endpoints | Critical |
| 2 | ✅ Implemented | Share Link Expiry and Revocation Enforcement | High |
| 3 | ✅ Implemented | Self-Sharing Prevention in Share Creation | Medium |
| 4 | ✅ Implemented | Cascade Deletion Handling for Shares and Share Links | Medium |
Powered by Oplane
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ItemSharemodel for user-to-user sharing with read/edit permissionsShareLinkmodel for token-based public links with optional expiry/items/{id}/shares//items/{id}/share-links/GET /shared/{token}with expiry and revocation checksitemshareandsharelinktablesShareDialogcomponent with tabbed People/Links UISecurity surface (for threat modeling)
Test plan
Generated with Claude Code