Skip to content

[OP#XWI-109] Adds Wiki browsing capabilities to the search dialog - #24615

Draft
mereghost wants to merge 5 commits into
devfrom
feature/xwi-109-add-hierarchy-browsing-to-wiki-page-search
Draft

[OP#XWI-109] Adds Wiki browsing capabilities to the search dialog#24615
mereghost wants to merge 5 commits into
devfrom
feature/xwi-109-add-hierarchy-browsing-to-wiki-page-search

Conversation

@mereghost

Copy link
Copy Markdown
Contributor

⚠️ Related Work Package: XWI-109

What are you trying to accomplish?

This PR introduces a lot of stuff, nothing groundbreaking but quite a lot, the main hightlights are:

  • Internal::Queries::BrowsePages - a command that returns a hierarchy of pages starting from a certain identifier.
  • BrowsePagesService - the service that basically transforms the query result into PageSearchTreeNodes.
  • PageSearchTreeNode was refactored and made slightly smarter
  • PageSearchTreeNode::NodeKey was introduced to avoid spreading the knowledge of how node keys were calculated
  • PageSearchService was refactored to use the new PageSearchTreeNode functionality

Screenshots

Screenshot From 2026-08-05 14-22-55 Screenshot From 2026-08-05 14-23-11

Kharonus and others added 5 commits August 4, 2026 11:36
- It works on my machine edition
- Next step is to make the templates into a component and try to unify
  the usage of PageSearchTreeNode
The idea is to make sure that all rendered trees keep consistent node
options and icons.

We could proably extract mode behaviour to the helper but it may be too
right now.

Also updades the PagesController to directly render the components.
@mereghost
mereghost force-pushed the feature/xwi-109-add-hierarchy-browsing-to-wiki-page-search branch from ac4281f to 6ecb855 Compare August 5, 2026 13:06
@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown

Warning

Flaky specs

  • rspec ./spec/features/projects/create_spec.rb[1:12:3:2:2]
🤖 Ask Copilot to investigate

Copy the prompt below into a new comment on this PR to delegate the investigation to GitHub Copilot. It will look into the flakiness and open a separate pull request with you as reviewer.

@copilot The following spec(s) are flaky in CI (first seen on PR #24615, linked for reference only):

- `rspec ./spec/features/projects/create_spec.rb[1:12:3:2:2]`

Treat this as a standalone task, unrelated to PR #24615. Create a new branch from origin/dev and open a new pull request targeting dev — do not stack it on PR #24615 or reuse that branch.

Follow the playbook in docs/development/testing/handling-flaky-tests/README.md to find the root cause and fix the underlying race — do not skip, delete, or weaken the spec to make it pass; disabling is a last resort per the playbook, and only with a bug ticket. Verify the fix by running the spec(s) repeatedly (e.g. `script/bulk_run_rspec --run-count 10`).

If you cannot reproduce the flake or are not confident in a fix after reasonable investigation, do not fabricate a change or skip the spec to force CI green. Instead, leave the pull request in draft and document what you tried, the suspected cause, and any leads in its description, then assign @mereghost to take over.

Once the fix is verified, title the PR after the spec(s) it fixes, and use the PR description to explain the root cause, how the change resolves it, and the before/after results. Label the PR `flaky-spec`, assign @mereghost, and request a review from @mereghost.
On every commit, set @mereghost as the sole co-author with a `Co-authored-by:` trailer (use their GitHub no-reply email so it links to their account), so it is traceable who dispatched the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants