[OP#XWI-109] Adds Wiki browsing capabilities to the search dialog - #24615
Draft
mereghost wants to merge 5 commits into
Draft
[OP#XWI-109] Adds Wiki browsing capabilities to the search dialog#24615mereghost wants to merge 5 commits into
mereghost wants to merge 5 commits into
Conversation
- It works on my machine edition - Next step is to make the templates into a component and try to unify the usage of PageSearchTreeNode
The idea is to make sure that all rendered trees keep consistent node options and icons. We could proably extract mode behaviour to the helper but it may be too right now. Also updades the PagesController to directly render the components.
mereghost
force-pushed
the
feature/xwi-109-add-hierarchy-browsing-to-wiki-page-search
branch
from
August 5, 2026 13:06
ac4281f to
6ecb855
Compare
|
Warning Flaky specs
🤖 Ask Copilot to investigateCopy the prompt below into a new comment on this PR to delegate the investigation to GitHub Copilot. It will look into the flakiness and open a separate pull request with you as reviewer. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
This PR introduces a lot of stuff, nothing groundbreaking but quite a lot, the main hightlights are:
Internal::Queries::BrowsePages- a command that returns a hierarchy of pages starting from a certain identifier.BrowsePagesService- the service that basically transforms the query result intoPageSearchTreeNodes.PageSearchTreeNodewas refactored and made slightly smarterPageSearchTreeNode::NodeKeywas introduced to avoid spreading the knowledge of how node keys were calculatedPageSearchServicewas refactored to use the newPageSearchTreeNodefunctionalityScreenshots