Skip to content

[COMMS-935] Maintenance: Reuse Primer clipboard-copy element for activity copy-link items - #24485

Merged
akabiru merged 1 commit into
devfrom
maintenance/reuse-clipboard-copy-activity-links
Aug 5, 2026
Merged

[COMMS-935] Maintenance: Reuse Primer clipboard-copy element for activity copy-link items#24485
akabiru merged 1 commit into
devfrom
maintenance/reuse-clipboard-copy-activity-links

Conversation

@akabiru

@akabiru akabiru commented Jul 28, 2026

Copy link
Copy Markdown
Member

https://community.openproject.org/wp/COMMS-935

Reuse Primer clipboard-copy element for activity copy-link items; no need for a custom Stimulus controller with a single action.

@akabiru akabiru self-assigned this Jul 28, 2026
@akabiru akabiru added this to the 17.8.x milestone Jul 28, 2026
@myabc

myabc commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

@akabiru nice!

@akabiru
akabiru marked this pull request as ready for review July 29, 2026 12:56
@akabiru akabiru changed the title Maintenance: Reuse Primer clipboard-copy element for activity copy-link items [COMMS-935] Maintenance: Reuse Primer clipboard-copy element for activity copy-link items Jul 29, 2026
@akabiru
akabiru requested review from a team and myabc July 29, 2026 12:59
@github-actions

github-actions Bot commented Jul 29, 2026

Copy link
Copy Markdown

Deploying openproject with PullPreview

Field Value
Latest commit 1a984c6
Job deploy
Status ✅ Deploy successful
Preview URL https://pr-24485-reuse-clipboard-c-ip-128-140-89-31.my.opf.run:443

View logs

@judithroth judithroth left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for always improving our code base Kabiru! 🌟

The activities tab carried its own Stimulus controller for a single
navigator.clipboard call, duplicating the clipboard-copy element the
action menus elsewhere already use. Dropping it also fixes the revision
entry's copy item, which pointed at a controller never mounted on its
wrapper.
@akabiru
akabiru force-pushed the maintenance/reuse-clipboard-copy-activity-links branch from d234091 to 1a984c6 Compare August 5, 2026 12:52
@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown

Warning

Flaky specs

  • rspec ./spec/features/projects/lists/filters_spec.rb[1:6:1]
🤖 Ask Copilot to investigate

Copy the prompt below into a new comment on this PR to delegate the investigation to GitHub Copilot. It will look into the flakiness and open a separate pull request with you as reviewer.

@copilot The following spec(s) are flaky in CI (first seen on PR #24485, linked for reference only):

- `rspec ./spec/features/projects/lists/filters_spec.rb[1:6:1]`

Treat this as a standalone task, unrelated to PR #24485. Create a new branch from origin/dev and open a new pull request targeting dev — do not stack it on PR #24485 or reuse that branch.

Follow the playbook in docs/development/testing/handling-flaky-tests/README.md to find the root cause and fix the underlying race — do not skip, delete, or weaken the spec to make it pass; disabling is a last resort per the playbook, and only with a bug ticket. Verify the fix by running the spec(s) repeatedly (e.g. `script/bulk_run_rspec --run-count 10`).

If you cannot reproduce the flake or are not confident in a fix after reasonable investigation, do not fabricate a change or skip the spec to force CI green. Instead, leave the pull request in draft and document what you tried, the suspected cause, and any leads in its description, then assign @akabiru to take over.

Once the fix is verified, title the PR after the spec(s) it fixes, and use the PR description to explain the root cause, how the change resolves it, and the before/after results. Label the PR `flaky-spec`, assign @akabiru, and request a review from @akabiru.
On every commit, set @akabiru as the sole co-author with a `Co-authored-by:` trailer (use their GitHub no-reply email so it links to their account), so it is traceable who dispatched the fix.

@akabiru
akabiru merged commit 6d286c3 into dev Aug 5, 2026
19 checks passed
@akabiru
akabiru deleted the maintenance/reuse-clipboard-copy-activity-links branch August 5, 2026 16:08
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 5, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Development

Successfully merging this pull request may close these issues.

3 participants