[COMMS-935] Maintenance: Reuse Primer clipboard-copy element for activity copy-link items - #24485
Merged
Merged
Conversation
Contributor
|
@akabiru nice! |
akabiru
marked this pull request as ready for review
July 29, 2026 12:56
Deploying openproject with ⚡ PullPreview
|
judithroth
approved these changes
Aug 3, 2026
judithroth
left a comment
Contributor
There was a problem hiding this comment.
Thanks for always improving our code base Kabiru! 🌟
The activities tab carried its own Stimulus controller for a single navigator.clipboard call, duplicating the clipboard-copy element the action menus elsewhere already use. Dropping it also fixes the revision entry's copy item, which pointed at a controller never mounted on its wrapper.
akabiru
force-pushed
the
maintenance/reuse-clipboard-copy-activity-links
branch
from
August 5, 2026 12:52
d234091 to
1a984c6
Compare
|
Warning Flaky specs
🤖 Ask Copilot to investigateCopy the prompt below into a new comment on this PR to delegate the investigation to GitHub Copilot. It will look into the flakiness and open a separate pull request with you as reviewer. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://community.openproject.org/wp/COMMS-935
Reuse Primer clipboard-copy element for activity copy-link items; no need for a custom Stimulus controller with a single action.