[XWI-142] Enable wiki macros in more editors - #24480
Conversation
Move the `wikisAvailable` check into the central CKEditor macro resolver and add a `wiki` macro preset, so any editor can opt in with a one-liner instead of repeating the logic.
The places are: - comments (activity) - custom fields (long text) - custom fields help text - meetings: - description - outcomes - agenda item
|
Warning Flaky specs
🤖 Ask Copilot to investigateCopy the prompt below into a new comment on this PR to delegate the investigation to GitHub Copilot. It will look into the flakiness and open a separate pull request with you as reviewer. |
NobodysNightmare
left a comment
There was a problem hiding this comment.
Overall this looks like a valid extension of the existing ICKEditorMacroType, which seems to have been intended exactly like this.
I can't say that I am a huge fan of this type and if anything, I'd urge to strengthen documentation around it and stricten type definitions up where-ever possible.
| if (resolved === 'none') { | ||
| return false; | ||
| } | ||
| if (resolved === 'resource') { |
There was a problem hiding this comment.
❓ Looking at the diff, this wasn't handled before as well, but do you know what we do for full?
There was a problem hiding this comment.
Just to confirm: The handling of full/true was added by you after my comment right? But we have no places that call it with full?
Asking because the "enable wikis no matter what" behaviour seems like we never really want it to happen ^ ^
On the other hand it makes sense to keep supporting true, if that's also natively supported.
|
Warning Flaky specs
🤖 Ask Copilot to investigateCopy the prompt below into a new comment on this PR to delegate the investigation to GitHub Copilot. It will look into the flakiness and open a separate pull request with you as reviewer. |
Ticket
XWI-142
What are you trying to accomplish?
Centralise CKEditor wiki macro.
Add the wiki macro to CKEditor in many places.
The places are:
Screenshots
Merge checklist