You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
🌱 bump github.com/prometheus/common from 0.72.1 to 0.73.1 - #3961
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.
Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase will rebase this PR
@dependabot recreate will recreate this PR, overwriting any edits that have been made to it
@dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
@dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
Summary by CodeRabbit
New Features
Added support for parsing OpenMetrics 1.0 text expositions, including metric families, labels, timestamps, and exemplars.
Added support for encoding with the OpenMetrics 2.0 release candidate format.
Bug Fixes
OpenMetrics format negotiation now applies escaping settings from the matching Accept clause.
Unsupported or malformed OpenMetrics versions now return clear errors instead of falling back to classic text decoding.
I'm waiting for a operator-framework member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.
Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 7 remain after this review.
Walkthrough
The update vendors go-abnf v0.5.3 and upgrades Prometheus common to v0.73.1. The vendored library adds ABNF parsing, recognition, generation, graph, regex, and parser-code generation APIs. The Prometheus common update adds OpenMetrics 1.0 decoding and 2.0.0-rc format and encoding support.
Changes: ABNF and OpenMetrics integration
Layer / File(s)
Summary
ABNF package foundation go.mod, vendor/modules.txt, vendor/github.com/pandatix/go-abnf/*
Adds go-abnf v0.5.3 and its ABNF grammar model, definitions, errors, options, utility functions, and package documentation and metadata.
Grammar parsing and recognition vendor/github.com/pandatix/go-abnf/grammar.go, leftrec.go, recognize.go, sppf.go, bsr.go
Adds ABNF parsing and evaluation, left-recursion analysis, input recognition, and GLL parse-forest APIs.
Grammar analysis and parser generation vendor/github.com/pandatix/go-abnf/dag.go, regex.go, regex_fuzz.go, codegen.go
Adds dependency-cycle analysis, regex conversion, and generation of standalone Go parsers.
Grammar generation and transition graphs vendor/github.com/pandatix/go-abnf/ast.go, generate.go, fuzz.go, transition_graph.go, *_fuzz.go
Adds grammar and AST generation, transition-graph construction and traversal, graph-based generation, near-miss analysis, and fuzz targets.
OpenMetrics decoding and formats go.mod, vendor/modules.txt, vendor/github.com/prometheus/common/expfmt/*
Upgrades Prometheus common to v0.73.1. Adds OpenMetrics 1.0 parsing and updates OpenMetrics format selection and encoding behavior, including 2.0.0-rc support.
Sequence Diagram(s)
sequenceDiagram
participant Caller
participant NewDecoder
participant openMetricsDecoder
participant ABNFParser
participant MetricFamily
Caller->>NewDecoder: Select decoder for OpenMetrics format
NewDecoder->>openMetricsDecoder: Create decoder
openMetricsDecoder->>ABNFParser: Parse exposition lines
ABNFParser-->>openMetricsDecoder: Parsed line results
openMetricsDecoder->>MetricFamily: Assemble and emit completed families
This is a routine dependency bump that vendors a new parsing library and adds OpenMetrics 1.0 decoding support. No first-party code uses the changed decoding path and the Go version requirements are met, so no merge-blocking risk was found.
Pre-merge checks: 4 · 1
Failed checks: 1 warning
Check name
Status
Explanation
Resolution
Docstring Coverage
Docstring coverage is 34.44% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documenta…
Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed checks: 4 passed
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title names a dependency bump of github.com/prometheus/common from 0.72.1 to 0.73.1. The changeset does exactly that in go.mod and vendor/modules.txt, and it brings in the vendored expfmt changes …
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Title check
Explanation
The title names a dependency bump of github.com/prometheus/common from 0.72.1 to 0.73.1. The changeset does exactly that in go.mod and vendor/modules.txt, and it brings in the vendored expfmt changes (OpenMetrics 1.0 parser, 2.0.0-rc format, escaping changes) and the go-abnf 0.5.3 dependency. The title is specific, concise, and matches the main change. The leading ':seedling:' emoji is a minor style point and does not make the title unclear.
Full details: Docstring Coverage
Explanation
Docstring coverage is 34.44% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 90 functions across 25 files. (9 skipped: 9 unsupported.)
Resolution
Write docstrings for the functions missing them to satisfy the coverage threshold.
Finishing Touches
Generate docstrings
Commit to this branch
Create a new PR
Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Warning
Some tools did not complete. Review the errors below.
golangci-lint (2.14.0)
golangci-lint (2.14.0) skipped for .golangci.yaml: configuration requires version: "2". Migrate older configurations using golangci-lint migrate and review the result; see https://golangci-lint.run/docs/product/migration-guide/.
CodeRabbit Verify
Run CodeRabbit Verify to test the changes in this pull request.
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
openshift-ciBot
added
ok-to-test
Indicates a non-member PR verified by an org member that is safe to test.
and removed
needs-ok-to-test
Indicates a PR that requires an org member to verify it is safe to test.
labels
Nov 3, 2026
openshift-ciBot
added
lgtm
Indicates that a PR is ready to be merged.
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
labels
Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
approvedIndicates a PR has been approved by an approver from all required OWNERS files.dependenciesPull requests that update a dependency filegoPull requests that update Go codelgtmIndicates that a PR is ready to be merged.ok-to-testIndicates a non-member PR verified by an org member that is safe to test.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dependabot
Bot
added
dependencies
Bumps github.com/prometheus/common from 0.72.1 to 0.73.1.
Release notes
Sourced from github.com/prometheus/common's releases.
Changelog
Sourced from github.com/prometheus/common's changelog.
Commits
d92d839build(deps): bump github.com/pandatix/go-abnf from 0.5.1 to 0.5.3 (#1027)983d509expfmt: add ABNF-based OpenMetrics 1.0 parser (#1015)220c51aexpfmt: add FmtOpenMetrics_2_0_0_rc format constant (#1020)25bdf5cexpfmt: default to allow-utf-8 escaping for OpenMetrics 2.0 (#1008)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)Summary by CodeRabbit
New Features
Bug Fixes
Acceptclause.