Skip to content

fix(ci): restore id-based credential matching for Maven 3.10 deploys - #340

Merged
csviri merged 1 commit into
mainfrom
fix/maven-3.10-credential-scope
Nov 3, 2026
Merged

csviri merged 1 commit into
mainfrom
fix/maven-3.10-credential-scope

Conversation

@csviri

@csviri csviri commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

Maven 3.10 scopes server credentials to declared repository origins, and the 'central' server written by actions/setup-java only declares repo.maven.apache.org, so uploads to central.sonatype.com are sent unauthenticated and rejected with HTTP 401.

Summary by CodeRabbit

  • Chores
    • Updated snapshot and Maven Central release publishing configuration to specify repository credential handling.

Maven 3.10 scopes server credentials to declared repository origins, and
the 'central' server written by actions/setup-java only declares
repo.maven.apache.org, so uploads to central.sonatype.com are sent
unauthenticated and rejected with HTTP 401.
@coderabbitai

coderabbitai Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Walkthrough

Both Maven release workflows now pass -Dmaven.repository.credentialScope=id to their Maven commands.

Changes: Maven release workflows

Layer / File(s) Summary
Set credential scope in release commands
.github/workflows/master-snapshot-release.yml, .github/workflows/release.yml
The snapshot release and Maven Central publish commands now pass -Dmaven.repository.credentialScope=id.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix

Suggested labels: java

Merge Risk: Minimal · up to 67bb7

The changes align both release commands with ID-based credential matching. No actionable merge-blocking issue is established by the supplied evidence.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title names the actual change: restoring ID-based credential matching for Maven 3.10 deploys. The summaries confirm both workflows (master-snapshot-release.yml and release.yml) add -Dmaven.reposit…
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the actual change: restoring ID-based credential matching for Maven 3.10 deploys. The summaries confirm both workflows (master-snapshot-release.yml and release.yml) add -Dmaven.repository.credentialScope=id to their Maven commands. The title is specific, concise, and follows the conventional commit format. It is a single sentence with no file lists, emojis, or vague terms.

Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.)

Finishing Touches
Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

CodeRabbit Verify

  • Run CodeRabbit Verify to test the changes in this pull request.
Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: dc9ac92b-82bb-457e-8bee-7d87217b8ae4
Commits

Reviewing files that changed from the base of the PR and between 2b51724 and 67bb7c8.

Files selected for processing: 2
  • .github/workflows/master-snapshot-release.yml
  • .github/workflows/release.yml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

@csviri
csviri merged commit dda6346 into main Nov 3, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant