Repository navigation
luci-theme-footstrap: sync with release 0.14.14 - #9111
Merged
Merged
Conversation
openwrt-ai
reviewed
Oct 6, 2026
openwrt-ai
left a comment
openwrt-ai
left a comment
Collaborator
There was a problem hiding this comment.
Commit checks
- 8bfeec2 "luci-theme-footstrap: sync with release 0.14.14": the commit also removes the companion-package extension API: the
footstrap.settings.plugin/window.__fsPluginsloader,fs-search.addSource/refresh,window.__fsSearchSources, and therememberandnodeForSegsexports. Neither the commit message nor the PR body mentions this. Please name it in the body, because any out-of-tree plugin will stop loading without any message.
Generated by Claude Code
VizzleTF
force-pushed
the
footstrap-sync-0.14.14
branch
from
October 6, 2026 09:05
8bfeec2 to
09da943
Compare
openwrt-ai
reviewed
Oct 6, 2026
openwrt-ai
left a comment
openwrt-ai
left a comment
Collaborator
There was a problem hiding this comment.
Commit checks
- 09da943 "luci-theme-footstrap: sync with release 0.14.14": the commit body still leaves out that the companion-package extension API (
footstrap.settings.plugin/window.__fsPlugins,fs-search.addSource/refresh,remember/nodeForSegs) is removed. The PR body now lists it, but the PR body does not end up in git history, so add one line about it to the commit message.
Generated by Claude Code
VizzleTF
force-pushed
the
footstrap-sync-0.14.14
branch
from
October 7, 2026 05:58
09da943 to
65bdac2
Compare
openwrt-ai
reviewed
Oct 7, 2026
BKPepe
reviewed
Oct 7, 2026
BKPepe
left a comment
BKPepe
left a comment
Member
There was a problem hiding this comment.
This needs to be split up before it can be reasonably reviewed.
Changing 25+ files in a single commit is already difficult to review, but the bigger issue is that the commit combines multiple independent concerns and behavioural changes. A reviewer should be able to review the cleanup/refactoring separately from the SPA router, API removal and security-related changes.
Please split the work into logically independent commits, each with a clear purpose and a reviewable scope. A downstream release being a single commit is not a good reason to preserve that commit structure when submitting it to OpenWrt.
The checkbox switch is drawn on the input itself rather than on label[for], and framed tables keep their rounded top corners. Also fixes a dropdown popup overflowing a phone screen, hex accent ink in dark palettes, the progressbar value line, key/value table detection and a selectable Overview card header. An app's offset on a table cell no longer steps the row separator. Signed-off-by: Ivan Kvashonkin <vizzlef@gmail.com>
Removes the companion-package extension API: the footstrap.settings.plugin loader (window.__fsPlugins), fs-search addSource/refresh and window.__fsSearchSources, and the remember and nodeForSegs exports. Nothing in the tree used them. Signed-off-by: Ivan Kvashonkin <vizzlef@gmail.com>
Removes CSS rules nothing matches and tokens nothing reads, and declares five light-palette values once. Computed styles are unchanged. Signed-off-by: Ivan Kvashonkin <vizzlef@gmail.com>
Shared attribute and activation helpers move into fs-widgets, axes are exported as objects and the footer partial is inlined. Drops fallbacks for luci-base older than 24.10 and guards for elements the chrome always renders. It also drops module exports nothing in the tree reads. Signed-off-by: Ivan Kvashonkin <vizzlef@gmail.com>
The login form focuses through autofocus instead of an inline script, the head template validates its settings through two shared helpers with the same patterns and ranges, and the wallpaper upload reads the SVG with File.text(). The CGI handler and its CSP are unchanged. Signed-off-by: Ivan Kvashonkin <vizzlef@gmail.com>
The client router drops its fallbacks for luci-base older than 24.10. An inline script at the top of <body> records nodes a page appends to <body>; when such nodes remain, the next client-side navigation is a full page load. The Refreshing pill also stays clickable after navigation. Signed-off-by: Ivan Kvashonkin <vizzlef@gmail.com>
VizzleTF
force-pushed
the
footstrap-sync-0.14.14
branch
from
October 8, 2026 09:15
65bdac2 to
3090b20
Compare
openwrt-ai
reviewed
Oct 9, 2026
openwrt-ai
left a comment
openwrt-ai
left a comment
Collaborator
There was a problem hiding this comment.
Commit checks
- 9795412 "luci-theme-footstrap: use autofocus and shared input checks": the commit also shortens the three residual-risk notes in
_sanitizeSvg()(external DTD, TAB-obfuscatedjavascript:, presentation-attributeurl(), which the message does not mention. Add a line about it, or move those comment edits into their own commit.
Generated by Claude Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request details
Description
Sync
luci-theme-footstrapwith its 0.14.14 release, split by concern:.cbi-checkboxswitch is drawn on the<input>itself, not onlabel[for](what treewide: consistency with checkbox inputs / checkbox color change regression #9043 is waiting for), plus table, dropdown, progressbar and dark-palette fixes. CSS only.footstrap.settings.plugin/window.__fsPluginsloader,fs-search.addSource/refresh,window.__fsSearchSources, and theremember/nodeForSegsexports. Nothing in the tree used them.po/is untouched — Weblate owns it.Maintainer (preferred)
@VizzleTF
Tested on
OpenWrt version: OpenWrt 25.12.4 (apk) and OpenWrt 24.10.8 (opkg), x86_64 containers, each commit of the series
LuCI version: this branch
Web browser(s): Chromium (each commit); the release itself in Chromium, Firefox and WebKit