Skip to content

CI: don't skip required code-style checks on docs-only PRs#63

Merged
harrism merged 1 commit into
openvdb:mainfrom
harrism:mjh/ci-docs-only-required-checks
Jul 1, 2026
Merged

CI: don't skip required code-style checks on docs-only PRs#63
harrism merged 1 commit into
openvdb:mainfrom
harrism:mjh/ci-docs-only-required-checks

Conversation

@harrism

@harrism harrism commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Problem

Docs-only PRs (e.g. the CODEOWNERS PR #62) are stuck BLOCKED. The main ruleset marks the code-style checks (black, include guards, SPDX, whitespace) as required, but codestyle.yml used workflow-level paths-ignore for **.md/CODEOWNERS. A workflow skipped via paths-ignore never reports its checks, so the required checks sit at "Expected" forever and block the merge.

Fix

Remove paths-ignore from codestyle.yml. The lint jobs are cheap (ubuntu-latest) and now always run and report, satisfying the required checks on every PR including docs-only ones.

🤖 Generated with Claude Code

## Problem

Docs-only PRs (e.g. the CODEOWNERS PR openvdb#62) are stuck **BLOCKED**. The `main` ruleset marks the code-style checks (black, include guards, SPDX, whitespace) as **required**, but `codestyle.yml` used workflow-level `paths-ignore` for `**.md`/`CODEOWNERS`. A workflow skipped via `paths-ignore` never reports its checks, so the required checks sit at "Expected" forever and block the merge.

## Fix

Remove `paths-ignore` from `codestyle.yml`. The lint jobs are cheap (ubuntu-latest) and now always run and report, satisfying the required checks on every PR including docs-only ones.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Signed-off-by: Mark Harris <mharris@nvidia.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a GitHub Actions/branch protection interaction where docs-only pull requests were blocked because required code-style checks never reported when the codestyle.yml workflow was skipped via paths-ignore.

Changes:

  • Removed workflow-level paths-ignore for CODEOWNERS and **.md so the code-style workflow always runs on PRs targeting main.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@harrism
harrism merged commit db0f7e2 into openvdb:main Jul 1, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants