Skip to content

Add min_childkey_take_per_subnet hyperparameter#2734

Open
gztensor wants to merge 1 commit into
devnet-readyfrom
feat/min-ck-take-hyperparam
Open

Add min_childkey_take_per_subnet hyperparameter#2734
gztensor wants to merge 1 commit into
devnet-readyfrom
feat/min-ck-take-hyperparam

Conversation

@gztensor

@gztensor gztensor commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Description

Add a new hyperparameter min_childkey_take_per_subnet for the existing admin util extrinsic with matching name.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe):

Breaking Change

Introduces a new min_childkey_take_per_subnet field in get_subnet_hyperparams_v3.

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have run ./scripts/fix_rust.sh to ensure my code is formatted and linted correctly
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@gztensor gztensor self-assigned this Jun 9, 2026
@gztensor gztensor added the skip-cargo-audit This PR fails cargo audit but needs to be merged anyway label Jun 9, 2026
@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

🛡️ AI Review — Skeptic (security review)

VERDICT: SAFE

BASELINE scrutiny: established write-permission contributor, matching author/committer, branch feat/min-ck-take-hyperparam -> devnet-ready.

Static review found a small runtime RPC-info exposure plus matching tests. No .github/ai-review/*, workflow, build script, dependency, or lockfile changes were present in the PR diff.

Findings

No findings.

Conclusion

No malicious pattern or security vulnerability was found. The added field reads an existing u16 storage-derived value and does not add mutation, unchecked arithmetic, panic paths, origins, dependencies, or build-time execution surface.


🔍 AI Review — Auditor (domain review)

VERDICT: 👍

Gittensor: LIKELY; established write-permission contributor with substantial subtensor PR history. Overlap check found only unrelated PR #2638 touching the same subnet-info files.

Static review of the small runtime RPC-info addition found no domain issues. The new V3 hyperparameter entry reuses the existing U16 value type and reports get_effective_min_childkey_take(netuid), matching the childkey-take enforcement path and the added coverage in pallets/subtensor/src/tests/subnet_info.rs.

PR description matches the implementation. Auto-fix: none. Spec version: local/base spec_version is already 417; the live devnet query could not resolve from this sandbox, so no spec-version edit was made.

Findings

No findings.

Conclusion

The PR is narrowly scoped, additive for the forward-compatible V3 hyperparameter list, and covered by the existing subnet-info tests. No blocking correctness, migration, weight, origin, or documentation issues were found.

@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

🔄 AI review updated — Skeptic: SAFE Auditor: 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-cargo-audit This PR fails cargo audit but needs to be merged anyway

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant