Add min_childkey_take_per_subnet hyperparameter#2734
Conversation
🛡️ AI Review — Skeptic (security review)VERDICT: SAFE BASELINE scrutiny: established write-permission contributor, matching author/committer, branch feat/min-ck-take-hyperparam -> devnet-ready. Static review found a small runtime RPC-info exposure plus matching tests. No FindingsNo findings. ConclusionNo malicious pattern or security vulnerability was found. The added field reads an existing 🔍 AI Review — Auditor (domain review)VERDICT: 👍 Gittensor: LIKELY; established write-permission contributor with substantial subtensor PR history. Overlap check found only unrelated PR #2638 touching the same subnet-info files. Static review of the small runtime RPC-info addition found no domain issues. The new V3 hyperparameter entry reuses the existing PR description matches the implementation. Auto-fix: none. Spec version: local/base FindingsNo findings. ConclusionThe PR is narrowly scoped, additive for the forward-compatible V3 hyperparameter list, and covered by the existing subnet-info tests. No blocking correctness, migration, weight, origin, or documentation issues were found. |
|
🔄 AI review updated — Skeptic: SAFE Auditor: 👍 |
Description
Add a new hyperparameter
min_childkey_take_per_subnetfor the existing admin util extrinsic with matching name.Type of Change
Breaking Change
Introduces a new
min_childkey_take_per_subnetfield inget_subnet_hyperparams_v3.Checklist
./scripts/fix_rust.shto ensure my code is formatted and linted correctly